pkg-perl-maintainers team mailing list archive

[Lukas Märdian <2030731@xxxxxxxxxxxxxxxxxx>]

Review for Source Package: libdbix-simple-perl

[Summary]
This is a higher level abstraction layer to Perl's SQL/database wrapper (libdbi-perl).

MIR team ACK under the constraint to resolve the below listed
required TODOs and as much as possible having a look at the
recommended TODOs.

This does not need a security review

List of specific binary packages to be promoted to main: libdbix-simple-perl
Specific binary packages built, but NOT to be promoted to main: None

Notes:
- It passes through SQL statements to the DBI layer from trusted source code,
  so I don't feel like this needs security review.

Required TODOs:
#1 other Dependencies to MIR due to this:
 * libobject-accessor-perl binary and source package is in universe
 * libsql-abstract-perl binary and source package is in universe
 * libtext-table-perl binary and source package is in universe

Recommended TODOs:
#2 The package should get a team bug subscriber before being promoted
#3 Upstream & Debian/Ubuntu update history is sporadic
=> Maybe we can do a better job of at least packaging new versions in a timely
   manner, once this is in main. There are not too frequent releases upstream.
#4 Lintian hints, which might be worth looking at:
I: libdbix-simple-perl source: out-of-date-standards-version 4.1.3 (released 2017-12-27) (current is 4.6.2)
P: libdbix-simple-perl source: silent-on-rules-requiring-root [debian/control]
X: libdbix-simple-perl source: upstream-metadata-file-is-missing

[Duplication]
There is no other package in main providing the same functionality.

Some potential duplicates are listed in the command below, most of them in
universe, except libdbi-perl, which is being used by libdbix-simple-perl as
a lower-layer abstraction.
$ rmadison -c main -s mantic {libdbix-abstract-perl,libsql-abstract-perl,libdbix-class-perl,libdbix-easy-perl,libdbix-oo-perl,libdbix-safe-perl,libdbi-perl}
 libdbi-perl | 1.643-4 | mantic | source, amd64, arm64, armhf, i386, ppc64el, riscv64, s390x

[Dependencies]
OK:
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
  more tests now.

Problems:
- other Dependencies to MIR due to this:
 * libobject-accessor-perl binary and source package is in universe
 * libsql-abstract-perl binary and source package is in universe
 * libtext-table-perl binary and source package is in universe

[Embedded sources and static linking]
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard

Problems: None

[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
  xml, json, asn.1], network packets, structures, ...) from
  an untrusted source. (passing through SQL from trusted source code)
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates, signing, ...)

Problems: None

[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
  - test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- This does not need special HW for build or test
- no new python2 dependency
- Not a Python package
- Not a Go package

Problems: None

[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- debian/watch is present and looks ok (if needed, e.g. non-native)
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
  maintained the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list

Problems:
- Upstream update history is sporadic
- Debian/Ubuntu update history is sporadic
- Lintian hints:
I: libdbix-simple-perl source: out-of-date-standards-version 4.1.3 (released 2017-12-27) (current is 4.6.2)
P: libdbix-simple-perl source: silent-on-rules-requiring-root [debian/control]
X: libdbix-simple-perl source: upstream-metadata-file-is-missing

[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (the language has no direct MM)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests)
- no use of user nobody
- no use of setuid / setgid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- not part of the UI for extra checks
- no translation present, but none needed for this case (user visible)?

Problems: None

-- 
You received this bug notification because you are a member of Debian
Perl Group, which is subscribed to libdbix-simple-perl in Ubuntu.
https://bugs.launchpad.net/bugs/2030731

Title:
  [MIR] promote libdbix-simple-perl as a libmail-dmarc-perl dependency

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libdbix-simple-perl/+bug/2030731/+subscriptions