pkg-perl-maintainers team mailing list archive

[Ioanna Alifieraki <2122108@xxxxxxxxxxxxxxxxxx>]

Review for Source Package: libcrypt-urandom-perl

[Summary]

MIR team ACK under the constraint to resolve the below listed
required TODOs and as much as possible having a look at the
recommended TODOs.

This does need a security review, so I'll assign ubuntu-security

List of specific binary packages to be promoted to main: libcrypt-urandom-perl
Specific binary packages built, but NOT to be promoted to main: None

Required TODOs:
1. Symbols tracking not in place.
2. From bug description it is suggested debcrafters is the owining team.
Could you please confirm.
3. There are 3 packages in Suggested and Recommended that are not in main:
autoconf-archive, libmail-box-perl, lynx.
Could you please raise the issue in the next mir meeting to be decided whether
these packages shall be pulled in main.
4. The package should get a team bug subscriber before being promoted.

[Rationale, Duplication and Ownership]
There is no other package in main providing the same functionality.
TODO: A team is committed to own long term maintenance of this package.
The rationale given in the report seems valid and useful for Ubuntu

[Dependencies]
OK:
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
  more tests now.

Problems:
Other Dependencies to MIR due to this. 
Suggested packages autoconf-archive and libmail-box-perl and recommended package lynx are in universe.

[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries

Problems: None

[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
  xml, json, asn.1], network packets, structures, ...) from
  an untrusted source.
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- this makes appropriate (for its exposure) use of established risk
  mitigation features (dropping permissions, using temporary environments,
  restricted users/groups, seccomp, systemd isolation features,
  apparmor, ...)

Problems:
- does deal with cryptography (en-/decryption, certificates,
  signing, ...)

[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
  - test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- This does not need special HW for build or test
- no new python2 dependency

Problems: None

[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- debian/watch is present and looks ok (if needed, e.g. non-native)
- Upstream update history is good
- Debian/Ubuntu update history is good
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
  maintained the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list

Problems:
- symbols tracking is not in place.

[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (the language has no direct MM)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
  tests)
- no use of user 'nobody' outside of tests
- no use of setuid / setgid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit or libseed
- not part of the UI for extra checks
- no translation present, but none needed for this case (user visible)?

Problems: None


** Changed in: libcrypt-urandom-perl (Ubuntu)
     Assignee: Ioanna Alifieraki (joalif) => Eduardo Barretto (ebarretto)

-- 
You received this bug notification because you are a member of Debian
Perl Group, which is subscribed to libcrypt-urandom-perl in Ubuntu.
https://bugs.launchpad.net/bugs/2122108

Title:
  [MIR] libcrypt-urandom-perl as a dependency of libauthen-sasl-perl

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libcrypt-urandom-perl/+bug/2122108/+subscriptions