← Back to team overview

python-jenkins-developers team mailing list archive

[Bug 2018567] Re: Default timeout stopped working starting from urllib3 2.0.0

 

Fix proposed to branch: master
Review: https://review.opendev.org/c/jjb/python-jenkins/+/882757

** Changed in: python-jenkins
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Python
Jenkins Developers, which is subscribed to Python Jenkins.
https://bugs.launchpad.net/bugs/2018567

Title:
  Default timeout stopped working starting from urllib3 2.0.0

Status in Python Jenkins:
  In Progress

Bug description:
  urllib3 library does not use socket._GLOBAL_DEFAULT_TIMEOUT as it's
  default value starting from version 2.0.0. Now it uses it's own value.
  So, when timeout passed to it is compared to default one, it fails
  with the following trace:

   File "/usr/local/lib/python3.8/site-packages/jenkins/__init__.py", line 822, in get_info
      return json.loads(self.jenkins_open(
    File "/usr/local/lib/python3.8/site-packages/jenkins/__init__.py", line 560, in jenkins_open
      return self.jenkins_request(req, add_crumb, resolve_auth).text
    File "/usr/local/lib/python3.8/site-packages/jenkins/__init__.py", line 576, in jenkins_request
      self.maybe_add_crumb(req)
    File "/usr/local/lib/python3.8/site-packages/jenkins/__init__.py", line 373, in maybe_add_crumb
      response = self.jenkins_open(requests.Request(
    File "/usr/local/lib/python3.8/site-packages/jenkins/__init__.py", line 560, in jenkins_open
      return self.jenkins_request(req, add_crumb, resolve_auth).text
    File "/usr/local/lib/python3.8/site-packages/jenkins/__init__.py", line 579, in jenkins_request
      self._request(req))
    File "/usr/local/lib/python3.8/site-packages/jenkins/__init__.py", line 553, in _request
      return self._session.send(r, **_settings)
    File "/usr/local/lib/python3.8/site-packages/requests/sessions.py", line 701, in send
      r = adapter.send(request, **kwargs)
    File "/usr/local/lib/python3.8/site-packages/requests/adapters.py", line 483, in send
      timeout = TimeoutSauce(connect=timeout, read=timeout)
    File "/usr/local/lib/python3.8/site-packages/urllib3/util/timeout.py", line 119, in __init__
      self._connect = self._validate_timeout(connect, "connect")
    File "/usr/local/lib/python3.8/site-packages/urllib3/util/timeout.py", line 156, in _validate_timeout
      raise ValueError(
  ValueError: Timeout value connect was <object object at 0x7f960143b240>, but it must be an int, float or None.

To manage notifications about this bug go to:
https://bugs.launchpad.net/python-jenkins/+bug/2018567/+subscriptions



References