python-jenkins-developers team mailing list archive

[OpenStack Infra <1781381@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/jjb/python-jenkins/+/901965
Committed: https://opendev.org/jjb/python-jenkins/commit/6b757a7c364d641fd314975daffb412024e95c64
Submitter: "Zuul (22348)"
Branch:    master

commit 6b757a7c364d641fd314975daffb412024e95c64
Author: Christian Henz <c.henz@xxxxxxxxxxxxxxxxxx>
Date:   Tue Nov 28 16:35:22 2023 +0100

    Do not initialize Request headers with bytestring.
    
    Closes-Bug: 1781381
    Change-Id: I14fcf165988bfe5fadf680d31152327eccbab5f5


** Changed in: python-jenkins
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Python
Jenkins Developers, which is subscribed to Python Jenkins.
https://bugs.launchpad.net/bugs/1781381

Title:
  Cannot delete build using delete_build

Status in Python Jenkins:
  Fix Released

Bug description:
  Requirement already up-to-date: python-jenkins in
  .XXXXXXX/venv/lib/python3.6/site-packages (1.0.2)

  
  In line 357 of __init__.py (function maybe_add_crumb) the code fails on req.headers[self.crumb['crumbRequestField']] = self.crumb['crumb']

  at this point i have a value for self.crumb and req.headers is b''

  the error i get is "bytes' object does not support item assignment"

  trace

   File "XXXXXX.py", line 9, in <module>
      j.delete_build(r"Whale Watchers/Project Whale Watcher QA - Grouped", k)
    File "XXXXXX/venv/lib/python3.6/site-packages/jenkins/__init__.py", line 1354, in delete_build
      self._build_url(DELETE_BUILD, locals()), b''))
    File "XXXXXX/venv/lib/python3.6/site-packages/jenkins/__init__.py", line 540, in jenkins_open
      return self.jenkins_request(req, add_crumb, resolve_auth).text
    File "XXXXXX/venv/lib/python3.6/site-packages/jenkins/__init__.py", line 556, in jenkins_request
      self.maybe_add_crumb(req)
    File "XXXXXX/venv/lib/python3.6/site-packages/jenkins/__init__.py", line 357, in maybe_add_crumb
      req.headers[self.crumb['crumbRequestField']] = self.crumb['crumb']
  TypeError: 'bytes' object does not support item assignment

To manage notifications about this bug go to:
https://bugs.launchpad.net/python-jenkins/+bug/1781381/+subscriptions