| Thread Previous • Date Previous • Date Next • Thread Next |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hello again, Am 29.11.2014 um 23:55 schrieb Seyyed Razi Alavizadeh: > Hello again, > > I am sorry to argue with you so often lately, > > No problem, we just discuss to find the best solution that should > be applied to qpdfview. > > but I tried it and I don't think we gain by overriding Qt's > default palette mechanism. Especially since we also did not do that > for the progress line edit or the current thumbnail highlight. (I > think there actually was bug report about the latter some time > ago.) So I would go with the default focus-palette relation for the > time being. > > > The progress line edit is different, because it has always (when > typing and on search triggered) focus and therefore the progress is > filled with the active highlight color but in other side because > line edit has the focus on search triggered the view has not focus > and therefore progress is filled with inactive highlight color that > at least on Windows is some light gray that is close to color of > item's background and this means progress of item is useless > because we can't see it until we give focus to view, that is, we > click on some item. I attached a screenshot how this comes out at my end. The color is usually quite subdued, but I think this actually does the job that was originally intended, i.e. deemphasize all the clutter when several search processes progress concurrently. I do admit that the alternating rows might be confusing. Could this maybe resolved by using a Qt style sheet? Does disabling alternating row colors help on your end? Best regards, Adam. >> P.S.: I am responding directly since the mail seems to have >> arrived > this way, but shouldn't this go over the mailing list? > > Oops... I always answered your messages with clicking on textarea > provided by gmail for replaying... it seems gmail set you as > recipient instead of the mailing list :/ > > Best Regrads, Razi. > > 2014-11-29 14:18 GMT+03:30 Adam Reichold > <adam.reichold@xxxxxxxxxxx <mailto:adam.reichold@xxxxxxxxxxx>>: > > Hello Razi, > > Am 27.11.2014 um 23:36 schrieb Seyyed Razi Alavizadeh: >> Hello Adam, > >> Thanks for your great work, now the extended search dock works >> very good. I just suggest the following patch for painting >> progress with active highlight color even if the search dock view >> has not focus: > > I am sorry to argue with you so often lately, but I tried it and I > don't think we gain by overriding Qt's default palette mechanism. > Especially since we also did not do that for the progress line edit > or the current thumbnail highlight. (I think there actually was > bug report about the latter some time ago.) > > So I would go with the default focus-palette relation for the time > being. > > Best regards, Adam. > > P.S.: I am responding directly since the mail seems to have > arrived this way, but shouldn't this go over the mailing list? > >> === modified file sources/miscellaneous.cpp > >> --- sources/miscellaneous.cpp 2014-11-27 20:32:34 +0000 > >> +++ sources/miscellaneous.cpp 2014-11-27 22:18:35 +0000 > >> @@ -574,7 +574,7 @@ > >> painter->save(); > >> painter->setCompositionMode(QPainter::CompositionMode_Multiply); > >> - painter->fillRect(highlightedRect, >> option.palette.highlight()); > >> + painter->fillRect(highlightedRect, >> option.palette.brush(QPalette::Active, QPalette::Highlight)); > >> painter->restore(); > >> } > > >> Best Regards, Razi. > > >> 2014-11-13 16:26 GMT+03:30 Seyyed Razi Alavizadeh >> <s.r.alavizadeh@xxxxxxxxx <mailto:s.r.alavizadeh@xxxxxxxxx> > <mailto:s.r.alavizadeh@xxxxxxxxx > <mailto:s.r.alavizadeh@xxxxxxxxx>>>: > >> Hello Adam, > >> Personally, I tried this and that, but have yet to reach >> something that seems to fit properly. > > >> I think the simpler & cleaner solution is that cancel-search >> action cancel all searches but doesn't close dock and also >> doesn't clear results and for progress-bar we can use >> itemDelegate of parent items. > >> However, I think we should just release 0.4.13 as it is on the >> next weekend to get more user feedback and make sure we find any >> regression as early as possible. > >> Opinions? > > >> Good idea. > >> Best Regards, Razi. > >> 2014-11-09 22:32 GMT+03:30 Adam Reichold >> <adam.reichold@xxxxxxxxxxx <mailto:adam.reichold@xxxxxxxxxxx> >> <mailto:adam.reichold@xxxxxxxxxxx > <mailto:adam.reichold@xxxxxxxxxxx>>>: > >> Hello, > >> as Razi pointed out, the extended search dock makes the current >> handling of the cancel-search action inappropriate, i.e. it >> should become possible to just cancel the in-flight search >> processes without closing the search dock and clearing all >> results up to this point. > >> Personally, I tried this and that, but have yet to reach >> something that seems to fit properly. However, I think we should >> just release 0.4.13 as it is on the next weekend to get more >> user feedback and make sure we find any regression as early as >> possible. > >> Opinions? > >> Best regards, Adam. > >> -- Mailing list: https://launchpad.net/~qpdfview Post to : >> qpdfview@xxxxxxxxxxxxxxxxxxx >> <mailto:qpdfview@xxxxxxxxxxxxxxxxxxx> > <mailto:qpdfview@xxxxxxxxxxxxxxxxxxx > <mailto:qpdfview@xxxxxxxxxxxxxxxxxxx>> >> Unsubscribe : https://launchpad.net/~qpdfview More help : >> https://help.launchpad.net/ListHelp > > > > >> -- Alavizadeh, Sayed Razi My Blog: http://pozh.org >> <http://pozh.org/> Saaghar (نرمافزار شعر): >> http://saaghar.pozh.org/ Saaghar Fan Page: >> http://www.facebook.com/saaghar.p Saaghar Mailing List: >> http://groups.google.com/group/saaghar > > > >> -- Alavizadeh, Sayed Razi My Blog: http://pozh.org >> <http://pozh.org/> Saaghar (نرمافزار شعر): >> http://saaghar.pozh.org/ Saaghar Fan Page: >> http://www.facebook.com/saaghar.p Saaghar Mailing List: >> http://groups.google.com/group/saaghar > > > > > > -- Alavizadeh, Sayed Razi My Blog: http://pozh.org > <http://pozh.org/> Saaghar (نرمافزار شعر): > http://saaghar.pozh.org/ Saaghar Fan Page: > http://www.facebook.com/saaghar.p Saaghar Mailing List: > http://groups.google.com/group/saaghar > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJUe057AAoJEPSSjE3STU344v8H/1R5MmY1r9lZxe8/bWTdU9SV kgdITYj/+U4JsGJTIx7K0nn3XiRFSLe7muYQZ+C1sPSZPC3mkuvVKPHUwWps02sC gYiZiyVWN1C+getXmpFSK0hhl70Nw7utIUtw90moAjo9ugy6sJJ0A5hPUMnwJcvl XQWfsqRJMYSjJMIqbS/pcqHsgvh5Rh0YiZWVtHTJdv0LXVSvmiCo1iP/cBseEPrf M8W6yseObsz1cUsWXoeh56g4IpR7nj+Z6FWG1PXYAbGL3owHM5VkLYV8vSj5PAAV n1wlxLcQDdizSTw9EJTOqE6WqOlNYPuQkyJr6UNYlaNXh74Cu4k+5ZZ3+k/X7LY= =ulHQ -----END PGP SIGNATURE-----
Attachment:
screen1.png
Description: PNG image
Attachment:
screen2.png
Description: PNG image
| Thread Previous • Date Previous • Date Next • Thread Next |
