qreator-discuss team mailing list archive

[David Planella <david.planella@xxxxxxxxxx>]

Al 21/11/12 11:59, En/na Stefan Schwarzburg ha escrit:
> Hi David,
> 
> just looked into your color-editor branch. I'll commend on the merge
> proposal, but I would love to see symbolic icons for the color selector,
> so I drew something with inkscape.
> 
> Could you have a look and tell me if you think this is worth continuing...?
> 
> Cheers,
> Stefan
> 
> 

Hi Stefan,

I like your symbolic icon, thanks! The only piece of feedback that I
have is that if we were to ship custom symbolic icons, I'd make them
monochrome as the rest of the application's icons.

Let me add part of the reply I sent with the merge proposal:

I do want to have symbolic icons in there, and your help would be really
appreciated. However, and even though I started creating some icons
myself (see [1]), I see it more as a low priority, as the things to get
ready for the release start piling up.

My only concern with shipping custom icons is that we're effectively
hardcoding them: we'll make them so that they resemble the default
symbolic theme, but if the style of the theme changes in the next Ubuntu
release, we'd need to change them too.

One added issue is that since the icons that we'd ship would have to be
loaded as images instead of icons from the standard theme path, they
would look slightly different from the rest of the icons on other buttons.

One thing is colour (the symbolic icons' colour is loaded from the theme
settings, which we'd have to emulate by hardcoding that colour into our
icons, see some background here [2]). In my experience the other is size
(last time I tried, images in buttons were smaller than same-sized icons).

So my recommendation would be to leave custom symbolic icons for now
(except for perhaps looking again at those from the theme, to see if we
can indeed find appropriate ones for the color selection and swap
actions), and revisit them after release. Does that make sense?

Cheers,
David.

[1]
http://bazaar.launchpad.net/~dpm/qreator/color-editor/view/99/data/media/color-selection-symbolic.svg
(despite of the name, I think this icon should be more suitable for the
'swap colors' button)
[2]
http://askubuntu.com/questions/148955/why-do-the-gnome-symbolic-icons-appear-darker-in-a-running-application/

Attachment: signature.asc
Description: OpenPGP digital signature