← Back to team overview

qreator-discuss team mailing list archive

Re: launchpad question

 

On Mon, May 20, 2013 at 8:46 AM, David Planella
<david.planella@xxxxxxxxxx>wrote:

> Al 20/05/13 08:31, En/na Stefan Schwarzburg ha escrit:
> > HI David,
> >
> > I have changed the branch, but I have a launchpad question: should I set
> > the status of that branch now to "resubmit" (as in "I have addressed the
> > issues, this is a resubmit"), or is the "resubmit" meant to communicate
> > to the submitter that he should resubmit?
> >
>
> The latter. As a reviewer, you set the status to "Resubmit" to indicate
> the branch author he should resubmit.
>
> If you do changes to the branch and make a commit or more, the merge
> proposal is automatically updated. As a convention, after this happens
> the branch author generally sends a comment to notify the reviewers, who
> then get an e-mail as a heads up.
>
> So everything's fine, I'll see if I can have a look at the new changes
> some time this morning.
>
>

I will be away till tuesday evening, so if you want to continue, you can
merge the branch...

Cheers,
Stefan

Thanks!
>

Cheers,
> David.
>
>
> --
> Mailing list: https://launchpad.net/~qreator-discuss
> Post to     : qreator-discuss@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~qreator-discuss
> More help   : https://help.launchpad.net/ListHelp
>
>

References