quickly-talk team mailing list archive

[tony byrne <tony.badwolf@xxxxxxxxx>]

Hi Didier
 A problem with the quickly supplied tests is that you need to be a
member of quickly to get them to pass, this discourages running and
writing tests!

e.g.

quickly_12.04$ ./test/one-test.sh quickly/test/completion.sh
Running test completion.sh...
********************************
--- quickly/test/completion.sh	2012-05-06 02:13:09.000000000 +0100
+++ /home/tony/trunk-branch/branches/quickly_12.04/results.log	2012-06-28
22:47:09.000000000 +0100
@@ -159,7 +159,19 @@
 ## For this one, we provide an actual string to finish completing, to
help make the results consistent between users

 quickly shell-completion quickly configure ppa quickly/
-# quickly/daily-build quickly/ppa
+# Traceback (most recent call last):
+#   File "/home/tony/trunk-branch/branches/quickly_12.04/data/templates/ubuntu-application/configure.py",
line 66, in <module>
+#     templatetools.handle_additional_parameters(sys.argv, help,
shell_completion, usage=usage)
+#   File "/home/tony/trunk-branch/branches/quickly_12.04/quickly/templatetools.py",
line 51, in handle_additional_parameters
+#     shell_completion(args[2:])
+#   File "/home/tony/trunk-branch/branches/quickly_12.04/data/templates/ubuntu-application/configure.py",
line 61, in shell_completion
+#     rv = packaging.shell_complete_ppa(argv[-1])
+#   File "/home/tony/trunk-branch/branches/quickly_12.04/data/templates/ubuntu-application/internal/packaging.py",
line 314, in shell_complete_ppa
+#     (ppa_user, ppa_name) = get_ppa_parameters(launchpad, ppa_to_complete)
+#   File "/home/tony/trunk-branch/branches/quickly_12.04/data/templates/ubuntu-application/internal/packaging.py",
line 348, in get_ppa_parameters
+#     raise not_ppa_owner(ppa_user_name)
+# internal.packaging.not_ppa_owner: quickly
+# None

 quickly shell-completion quickly configure target-distribution foo
 #
@@ -213,7 +225,19 @@
 # --help --ppa --staging --template --verbose --version -h -t

 quickly shell-completion quickly release --ppa quickly/
-# quickly/daily-build quickly/ppa
+# Traceback (most recent call last):
+#   File "/home/tony/trunk-branch/branches/quickly_12.04/data/templates/ubuntu-application/release.py",
line 73, in <module>
+#     templatetools.handle_additional_parameters(sys.argv, help,
shell_completion, usage=usage)
+#   File "/home/tony/trunk-branch/branches/quickly_12.04/quickly/templatetools.py",
line 51, in handle_additional_parameters
+#     shell_completion(args[2:])
+#   File "/home/tony/trunk-branch/branches/quickly_12.04/data/templates/ubuntu-application/release.py",
line 68, in shell_completion
+#     rv = packaging.shell_complete_ppa(argv[-1])
+#   File "/home/tony/trunk-branch/branches/quickly_12.04/data/templates/ubuntu-application/internal/packaging.py",
line 314, in shell_complete_ppa
+#     (ppa_user, ppa_name) = get_ppa_parameters(launchpad, ppa_to_complete)
+#   File "/home/tony/trunk-branch/branches/quickly_12.04/data/templates/ubuntu-application/internal/packaging.py",
line 348, in get_ppa_parameters
+#     raise not_ppa_owner(ppa_user_name)
+# internal.packaging.not_ppa_owner: quickly
+# None

 quickly shell-completion quickly release foo
 #
@@ -228,7 +252,19 @@
 # --help --ppa --staging --template --verbose --version -h -t

 quickly shell-completion quickly share --ppa quickly/
-# quickly/daily-build quickly/ppa
+# Traceback (most recent call last):
+#   File "/home/tony/trunk-branch/branches/quickly_12.04/data/templates/ubuntu-application/share.py",
line 74, in <module>
+#     templatetools.handle_additional_parameters(sys.argv, help,
shell_completion, usage=usage)
+#   File "/home/tony/trunk-branch/branches/quickly_12.04/quickly/templatetools.py",
line 51, in handle_additional_parameters
+#     shell_completion(args[2:])
+#   File "/home/tony/trunk-branch/branches/quickly_12.04/data/templates/ubuntu-application/share.py",
line 69, in shell_completion
+#     rv = packaging.shell_complete_ppa(argv[-1])
+#   File "/home/tony/trunk-branch/branches/quickly_12.04/data/templates/ubuntu-application/internal/packaging.py",
line 314, in shell_complete_ppa
+#     (ppa_user, ppa_name) = get_ppa_parameters(launchpad, ppa_to_complete)
+#   File "/home/tony/trunk-branch/branches/quickly_12.04/data/templates/ubuntu-application/internal/packaging.py",
line 348, in get_ppa_parameters
+#     raise not_ppa_owner(ppa_user_name)
+# internal.packaging.not_ppa_owner: quickly
+# None

 quickly shell-completion quickly share foo
 #
********************************
FAILED


On 27/06/2012, Didier Roche <didrocks@xxxxxxxxxx> wrote:
> Hey Dario, thanks for this patch and help to make Quickly better.
>
> You code looks overall good :) However, you can see that we have some
> automated tests with Quickly, would you mind writing some for this case?
> (use a dummy EDITOR = cat and cat -option variable)
> --
> https://code.launchpad.net/~berdario/quickly/editor-fix/+merge/111751
> Your team Quickly Developers is requested to review the proposed merge of
> lp:~berdario/quickly/editor-fix into lp:quickly.
>