qutimdevelop team mailing list archive

[Sebastien Bacher <seb128@xxxxxxxxxx>]

** Description changed:

  Impact:
  It's not possible to remove icons once added
  
  Test Case:
- - create some Messaging Menu menuitem with no icon (GIcon *icon = NULL), it is created with no icon, as it is supposed to be.
- - Then set some icon with messaging_menu_app_set_source_icon, and later I want to remove it.
- - call messaging_menu_app_set_source_icon again, providing NULL as pointer to icon
- 
- the icon should be removed
+ - download the file from comment #4
+ - Compile with:
+   cc reproduce-lp1070421.c `pkg-config --cflags --libs messaging-menu`
+ - "Something happened" will appear below the "Empathy" entry in the messaging menu. Without the fix to this bug, an "icon-not-found" icon will be displayed. With the fix, no icon should appear.
  
  Regression Potential:
- Check that the api does what it should
+ Limited, it makes work a case which was broken, if the fix is not correct it would keep not working
  ---
  
  At the moment if I create some Messaging Menu menuitem with no icon (GIcon *icon = NULL), it is created with no icon, as it is supposed to be.
  Then I set some icon with messaging_menu_app_set_source_icon, and later I want to remove it. I call messaging_menu_app_set_source_icon again, providing NULL as pointer to icon, and icon is not removed, but is set to some "icon-not-found" icon (I don't know real name for that icon).
  So the only way to remove icon from source is to completely remove it and create again. I suppose that it is a bug.

** Description changed:

  Impact:
  It's not possible to remove icons once added
  
  Test Case:
  - download the file from comment #4
  - Compile with:
-   cc reproduce-lp1070421.c `pkg-config --cflags --libs messaging-menu`
+   gcc reproduce-lp1070421.c -o testcase `pkg-config --cflags --libs messaging-menu`
  - "Something happened" will appear below the "Empathy" entry in the messaging menu. Without the fix to this bug, an "icon-not-found" icon will be displayed. With the fix, no icon should appear.
  
  Regression Potential:
  Limited, it makes work a case which was broken, if the fix is not correct it would keep not working
  ---
  
  At the moment if I create some Messaging Menu menuitem with no icon (GIcon *icon = NULL), it is created with no icon, as it is supposed to be.
  Then I set some icon with messaging_menu_app_set_source_icon, and later I want to remove it. I call messaging_menu_app_set_source_icon again, providing NULL as pointer to icon, and icon is not removed, but is set to some "icon-not-found" icon (I don't know real name for that icon).
  So the only way to remove icon from source is to completely remove it and create again. I suppose that it is a bug.

-- 
You received this bug notification because you are a member of QutIM
Developers, which is subscribed to qutim.
https://bugs.launchpad.net/bugs/1070421

Title:
  Unable to remove icon from menuitem

Status in The Messaging Menu:
  Fix Released
Status in Multiplatform instant messenger:
  Confirmed
Status in “indicator-messages” package in Ubuntu:
  In Progress
Status in “indicator-messages” source package in Quantal:
  In Progress

Bug description:
  Impact:
  It's not possible to remove icons once added

  Test Case:
  - download the file from comment #4
  - Compile with:
    gcc reproduce-lp1070421.c -o testcase `pkg-config --cflags --libs messaging-menu`
  - "Something happened" will appear below the "Empathy" entry in the messaging menu. Without the fix to this bug, an "icon-not-found" icon will be displayed. With the fix, no icon should appear.

  Regression Potential:
  Limited, it makes work a case which was broken, if the fix is not correct it would keep not working
  ---

  At the moment if I create some Messaging Menu menuitem with no icon (GIcon *icon = NULL), it is created with no icon, as it is supposed to be.
  Then I set some icon with messaging_menu_app_set_source_icon, and later I want to remove it. I call messaging_menu_app_set_source_icon again, providing NULL as pointer to icon, and icon is not removed, but is set to some "icon-not-found" icon (I don't know real name for that icon).
  So the only way to remove icon from source is to completely remove it and create again. I suppose that it is a bug.

To manage notifications about this bug go to:
https://bugs.launchpad.net/indicator-messages/+bug/1070421/+subscriptions