← Back to team overview

registry team mailing list archive

[Merge] lp:~jelmer/bzr-pqm/child-pqm-email into lp:bzr-pqm

 

Jelmer Vernooij has proposed merging lp:~jelmer/bzr-pqm/child-pqm-email into lp:bzr-pqm.

Requested reviews:
  Bzr-pqm-devel (bzr-pqm-devel): code


This adds a `child_pqm_email` setting similar to the `child_submit_to` setting that we already have. This option can be set in the submit branch and will be used for child branches that are submitted for merging into the submit branch.

This allows configuring the pqm email address only once for the submit branch rather than locally for every developer.
-- 
https://code.launchpad.net/~jelmer/bzr-pqm/child-pqm-email/+merge/25441
Your team Bzr-pqm-devel is requested to review the proposed merge of lp:~jelmer/bzr-pqm/child-pqm-email into lp:bzr-pqm.
=== modified file 'pqm_submit.py'
--- pqm_submit.py	2009-12-04 07:08:37 +0000
+++ pqm_submit.py	2010-05-17 15:06:32 +0000
@@ -242,7 +242,11 @@
     mail_from = mail_from.encode('utf8') # Make sure this isn't unicode
     mail_to = config.get_user_option('pqm_email')
     if not mail_to:
-        raise NoPQMSubmissionAddress(branch)
+        submit_branch = Branch.open(submit_location)
+        submit_branch_config = submit_branch.get_config()
+        mail_to = submit_branch_config.get_user_option('child_pqm_email')
+        if not mail_to:
+            raise NoPQMSubmissionAddress(branch)
     mail_to = mail_to.encode('utf8') # same here
 
     if not ignore_local:


Follow ups