registry team mailing list archive

[Martin Pitt <martin.pitt@xxxxxxxxxx>]

Indeed the previous patch would overwrite previous altsettings, sorry
that I didn't spot this. When I reviewed this original SRU, I just
looked at the realloc()/memset() sequence, which seems fine at the first
sight. realloc() by no way guarantees you that the reallocated pointer
is still the same as the original one, so you would have to copy the
previous contents if they are different. But the code does not do that
and blindly assumes that the pointer remains constant.

However, Pawel's patch avoids the regression in bug 595650 and does not
scribble over the previously written altsettings, so I'll sponsor this
into lucid. Thanks a lot!

** Changed in: libusb (Ubuntu Lucid)
     Assignee: (unassigned) => Martin Pitt (pitti)

** Tags removed: verification-done

-- 
usb_find_devices() crashed with SIGSEGV in free()
https://bugs.launchpad.net/bugs/427805
You received this bug notification because you are a member of Registry
Administrators, which is the registrant for libusb.