← Back to team overview

registry team mailing list archive

[Bug 604991] Re: Please merge tiger 1:3.2.3-3 (universe) from debian unstable (main)

 

I disagree with the first hunk of config changes. It seems upstream
creates a directory no matter where it is, so we don't need to make that
change. For the second hunk, why not keep the variable tempfile, just
change its initial value.


Note: I find the postrm change (which predates this merge) a bit strange. It could be written more readably (and efficiently) as:
find $dir \! -type d -delete
find $dir -type d -depth -delete

Then, the obvious simplification is:
find $dir -depth -delete

Or even:
rm -rf $dir

However, that's outside the realm of this review. The code works it's
just odd.

** Changed in: tiger (Ubuntu)
       Status: New => Incomplete

-- 
Please merge tiger 1:3.2.3-3 (universe) from debian unstable (main)
https://bugs.launchpad.net/bugs/604991
You received this bug notification because you are a member of Registry
Administrators, which is the registrant for Debian.