registry team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

Curtis Hovey has proposed merging lp:~sinzui/launchpad-news-wordpress-theme/escape-from-monkeys into lp:launchpad-news-wordpress-theme.

Requested reviews:
  Robert Collins (lifeless): code


This branch addresses the concerns raised in bug 632685.

I developed this fix by installing the same version of WordPress as used by Lp and setting the theme to the Lp theme. The problem was easy to reproduce. I chose the WP way of dealing with the issue (as used in the 2.8.4 search templates) instead of the way I initially suggest in the bug.
-- 
https://code.launchpad.net/~sinzui/launchpad-news-wordpress-theme/escape-from-monkeys/+merge/35046
Your team Registry Administrators is subscribed to branch lp:launchpad-news-wordpress-theme.

=== modified file 'header.php'
--- header.php	2009-02-12 12:23:56 +0000
+++ header.php	2010-09-09 22:26:42 +0000
@@ -22,7 +22,7 @@
             $query = 'Search blog archives';
         }
       ?>
-    <input type="search" accesskey="s" value="<?php echo $query; ?>" name="s" id="s" />
+    <input type="search" accesskey="s" value="<?php echo esc_attr($query); ?>" name="s" id="s" />
     <input type="hidden" name="blog_url" id="blog_url" value="<?php bloginfo('url'); ?>" />
     <a href="<?php bloginfo('rss2_url');?>" title="RSS Feed for Blog Entries"><img src="<?php bloginfo('template_directory'); ?>/images/rss.png" alt="RSS Feed" /></a>
     </div>