registry team mailing list archive
-
registry team
-
Mailing list archive
-
Message #15084
[Bug 385135] Re: immediately suspends on startup when lid is closed
Launchpad has imported 17 comments from the remote bug at
http://bugs.freedesktop.org/show_bug.cgi?id=22574.
If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.
------------------------------------------------------------------------
On 2009-07-01T01:28:01+00:00 Martin Pitt wrote:
This was originally filed against gnome-power-manager in
http://bugzilla.gnome.org/show_bug.cgi?id=585228, but I think it belongs
to dk-p.
2.27.1 now enables suspend on lid close by default. This is great in principle,
but it falls over if you keep your laptop in a docking station, and thus the
lid is closed all the time. When g-p-m starts up, the recent introduction of the "lid-is-closed" property into dk-p [1] and g-p-m [2] cause this:
1. g-p-m starts the very first time (such as in gdm)
2. This D-BUS activates devicekit-power-daemon
3. dk-p sends a lid event:
TI:10:18:00 TH:0x17f6050 FI:dkp-input.c FN:dkp_input_coldplug,255
- using /sys/devices/LNXSYSTM:00/device:00/PNP0C0D:00/input/input0/event0 for lid event
TI:10:18:00 TH:0x17f6050 FI:dkp-daemon.c FN:dkp_daemon_set_lid_is_closed,108
- lid_is_closed=1
4. g-p-m picks it up:
TI:10:06:35 TH:0xcb3d00 FI:gpm-button.c
FN:gpm_button_client_changed_cb,554
- ************* gpm_button_client_changed_cb: lid: 1
TI:10:06:35 TH:0xcb3d00 FI:gpm-button.c FN:gpm_button_emit_type,101
- emitting button-pressed : lid-down
TI:10:06:35 TH:0xcb3d00 FI:gpm-manager.c
FN:button_pressed_cb,737
- Button press event type=lid-down
TI:10:06:35 TH:0xcb3d00 FI:gpm-manager.c
FN:lid_button_pressed,645
- **************** lid_button_pressed 1
TI:10:06:35 TH:0xcb3d00 FI:gpm-manager.c
FN:lid_button_pressed,658
- Performing AC policy
TI:10:06:35 TH:0xcb3d00 FI:gpm-manager.c
FN:manager_policy_do,408
- policy: /apps/gnome-power-manager/buttons/lid_ac
IMHO dk-p should not emit a lid event on startup, since g-p-m and other
clients shoulnd't special-case dk-p activation. They need to work also
on second login, etc., when dk-p is already running.
[1] http://cgit.freedesktop.org/DeviceKit/DeviceKit-power/commit/?id=7bd2dfefcb88d2e40402f4e1272dd70255d34b87
[2] http://git.gnome.org/cgit/gnome-power-manager/commit/?id=90000eb88dbc4ef404f6be0940a0b64572c588ff
Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/385135/comments/4
------------------------------------------------------------------------
On 2009-07-01T02:59:46+00:00 Martin Pitt wrote:
Created an attachment (id=27290)
suppress initial change event
What do you think about this patch? It works for me.
Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/385135/comments/5
------------------------------------------------------------------------
On 2009-07-01T03:21:14+00:00 Richard Hughes wrote:
(In reply to comment #1)
> What do you think about this patch? It works for me.
Yup, please apply. Looks fine to me.
Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/385135/comments/6
------------------------------------------------------------------------
On 2009-07-01T03:26:22+00:00 Martin Pitt wrote:
> Yup, please apply. Looks fine to me.
Was that for me? (-EPERM)
Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/385135/comments/7
------------------------------------------------------------------------
On 2009-07-01T03:30:13+00:00 Richard Hughes wrote:
(In reply to comment #3)
> Was that for me? (-EPERM)
Sure. If you want commit then open bug in fd.o, cc me, and I'll give my
approval.
Are you sure that you've not got commit? -- I seem to remember that you
have commit on HAL, and the group list is the same as that IIRC.
If you can't be arsed, say so and I'll commit on your behalf :-)
Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/385135/comments/8
------------------------------------------------------------------------
On 2009-07-01T03:58:20+00:00 Martin Pitt wrote:
Yes, I already tried that a while ago:
$ ls -ld /git/DeviceKit/DeviceKit-power.git/
drwxrwsr-x 7 david devicekit 4096 2008-08-01 03:12 /git/DeviceKit/DeviceKit-power.git/
$ groups
freedesktop hal
So it's a different group.
I requested upload privs in bug 22578.
Thanks!
Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/385135/comments/9
------------------------------------------------------------------------
On 2009-07-01T04:03:54+00:00 Martin Pitt wrote:
Created an attachment (id=27294)
git formatted patch of the above
For your convenience. :-)
Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/385135/comments/10
------------------------------------------------------------------------
On 2009-07-01T04:22:11+00:00 Richard Hughes wrote:
(In reply to comment #6)
> Created an attachment (id=27294) [details]
> git formatted patch of the above
Committed. Thanks dude.
Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/385135/comments/11
------------------------------------------------------------------------
On 2009-07-06T08:18:02+00:00 Loïc Minier wrote:
Hi folks
This breaks the first suspend resume for me when I close the lid.
What happens is that:
1. on startup dkp assumes lid is closed
2. on input coldplug it detects lid as truly closed; this doesn't set initialized though
3. on the first lid event (lid close to suspend in my case) the event is swallowed because of this patch
I could offer a fix to set initialized in case 2. as well, but I don't
like the general approach very much. Instead I'd like to offer a
different approach which is to add a flag to set_lid_is_closed to
disable notifications and use that only on input coldplug.
Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/385135/comments/14
------------------------------------------------------------------------
On 2009-07-06T08:20:18+00:00 Loïc Minier wrote:
Created an attachment (id=27417)
Add a notify flag to set_lid_is_closed and use it only on input cold plug
Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/385135/comments/15
------------------------------------------------------------------------
On 2009-07-06T08:24:23+00:00 Loïc Minier wrote:
Created an attachment (id=27418)
git format patch of notify flag addition
Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/385135/comments/16
------------------------------------------------------------------------
On 2009-07-06T08:36:11+00:00 Loïc Minier wrote:
Created an attachment (id=27419)
log of dkp --verbose exposing the issue (before patch)
Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/385135/comments/17
------------------------------------------------------------------------
On 2009-07-06T08:36:50+00:00 Loïc Minier wrote:
Created an attachment (id=27420)
log of dkp --verbose once fixed (with the patch)
Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/385135/comments/18
------------------------------------------------------------------------
On 2009-07-06T09:22:20+00:00 Martin Pitt wrote:
Thanks, Loic. I like this approach better. I tried to apply it to 009,
but unfortunately I can't really test it since g-p-m bails out with
$ gnome-power-manager --debug
(gnome-power-manager:4054): devkit-power-gobject-WARNING **: unhandled property 'recall-vendor'
**
devkit-power-gobject:ERROR:dkp-device.c:193:dkp_device_collect_props_cb: code should not be reached
Aborted (core dumped)
I'll investigate this, and report back about this patch later here.
Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/385135/comments/19
------------------------------------------------------------------------
On 2009-07-06T09:28:45+00:00 Richard Hughes wrote:
(In reply to comment #13)
> Thanks, Loic. I like this approach better. I tried to apply it to 009, but
> unfortunately I can't really test it since g-p-m bails out with
You need to grab a patch for gnome-power-manager:
commit 655dc92e5b2259d008021d5258e77b00e3d5bfad
Author: Richard Hughes <richard@xxxxxxxxxxx>
Date: Fri Jul 3 10:11:09 2009 +0100
Be less asserty if newer enums get added to DeviceKit-power
If you're using a new DKP with an old g-p-m.
Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/385135/comments/20
------------------------------------------------------------------------
On 2009-07-06T09:30:34+00:00 Richard Hughes wrote:
(In reply to comment #10)
> Created an attachment (id=27418) [details]
> git format patch of notify flag addition
I've applied this, thanks.
Richard.
Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/385135/comments/21
------------------------------------------------------------------------
On 2009-07-06T10:24:51+00:00 Martin Pitt wrote:
Ah, apparently 009 broke ABI without bumping shlibs. A mere g-p-m
rebuild was enough.
I tested the patch now and confirm that it works just fine in both cases
(lid closed in docking, and lid open/first suspend).
Thanks!
Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/385135/comments/22
** Changed in: devicekit-power
Importance: Unknown => Medium
--
immediately suspends on startup when lid is closed
https://bugs.launchpad.net/bugs/385135
You received this bug notification because you are a member of Registry
Administrators, which is the registrant for gnome-power.
