registry team mailing list archive

[Michel-daenzer <550218@xxxxxxxxxxxxxxxxxx>]

I don't see(In reply to comment #16)
> Created an attachment (id=34628) [details]
> Make DRI2DestroyDrawable more robust if pDraw is invalid
> 
> If pDraw is invalid (i.e. we already freed the priv) don't try to use it to
> look up the screen.

I don't see how that can work - if the WindowRec pointed to by pDraw was
already freed, DRI2GetDrawable() can't be relied upon.

See e.g. commits 7b6400a1b8d2f228fcbedf17c30a7e3924e4dd2a ('glx: Fix
drawable private leak on destroy'),
2075d4bf9e53b8baef0b919da6c44771220cd4a5 ('glx: If a destroyed window is
bound to the current context, make it not current.') and
3020b1d43e34fca08cd51f7c7c8ed51497d49ef3 ('glx: Clean up more thoroughly
if the drawable of a current context goes away.') for how similar issues
were dealt with previously.

BTW, it may not be immediately related to this problem, but I suspect
commit 711e26466ae04ae93ff4c48d377d83d68a6320e9 ('DRI2: handle drawable
destruction properly at DRI2SwapComplete time') can't work properly for
windows - it tries to defer the drawable destruction, but that's not
possible for windows.

-- 
xserver crashes when closing application using clutter
https://bugs.launchpad.net/bugs/550218
You received this bug notification because you are a member of Registry
Administrators, which is the registrant for Debian.