← Back to team overview

registry team mailing list archive

[Bug 497130] Re: [PATCH]: gdm login screen should not offer hibernate option if no swap exists

 

Launchpad has imported 2 comments from the remote bug at
http://bugs.freedesktop.org/show_bug.cgi?id=25675.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2009-12-16T08:23:31+00:00 Debbie-beliveau-gmail wrote:

Created an attachment (id=32123)
Have dkp_daemon_check_swap function 1st  check if swap exists before determining how much is free

dkp_client_can_hibernate can return true even if the machine has no swap
partition.  When determining the value of its can_hibernate property,
devicekit-power checks if the kernel supports hibernate and whether
there is enough swap space available to perform a hibernate.  However,
it does not seem to account for the possibility that a machine may not
have a swap partition even though its kernel supports it.  In this case,
devicekit-power detects that the kernel supports hibernate and treats
the swap space as completely available (therefore
dkp_client_can_hibernate returns true).  The attached patch modifies
devicekit-power to first check if a swap partition exists before
calculating how much is available.

Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/497130/comments/2

------------------------------------------------------------------------
On 2009-12-16T08:30:24+00:00 Richard Hughes wrote:

Thanks for the patch, applied.

commit bbb102c394eff71d84801b48b11e022b1fecb497
Author: Debbie Beliveau <debbie.beliveau@xxxxxxxxx>
Date:   Wed Dec 16 16:29:29 2009 +0000

    Check if swap exists before determining how much is free
    
    Signed-off-by: Richard Hughes <richard@xxxxxxxxxxx>

:100644 100644 eb16a63... 47d84d5... M  src/dkp-daemon.c

Reply at: https://bugs.launchpad.net/devicekit-
power/+bug/497130/comments/3


** Changed in: devicekit-power
   Importance: Unknown => Medium

-- 
[PATCH]: gdm login screen should not offer hibernate option if no swap exists
https://bugs.launchpad.net/bugs/497130
You received this bug notification because you are a member of Registry
Administrators, which is the registrant for Debian.