registry team mailing list archive

[Bug Watch Updater <139017@xxxxxxxxxxxxxxxxxx>]

Launchpad has imported 5 comments from the remote bug at
http://bugs.freedesktop.org/show_bug.cgi?id=12673.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2007-10-04T05:05:51+00:00 Kimmo Hämäläinen wrote:

This crash would happen if NULL was passed as the pending_return
argument and the connection was disconnected. I'll attach a patch.

Reply at: https://bugs.launchpad.net/dbus/+bug/139017/comments/5

------------------------------------------------------------------------
On 2007-10-04T05:06:40+00:00 Kimmo Hämäläinen wrote:

Created an attachment (id=11897)
proposed patch

Reply at: https://bugs.launchpad.net/dbus/+bug/139017/comments/6

------------------------------------------------------------------------
On 2007-10-04T07:03:46+00:00 Hp-pobox wrote:

Shouldn't it add an "if (pending_return)" instead of removing the
assignment? (Was it already assigned to earlier in the code?)

Reply at: https://bugs.launchpad.net/dbus/+bug/139017/comments/7

------------------------------------------------------------------------
On 2007-10-04T23:22:14+00:00 Kimmo Hämäläinen wrote:

(In reply to comment #2)
> Shouldn't it add an "if (pending_return)" instead of removing the assignment?
> (Was it already assigned to earlier in the code?)

There is already a NULL assignment before that:

  if (pending_return)
    *pending_return = NULL;

  CONNECTION_LOCK (connection);

   if (!_dbus_connection_get_is_connected_unlocked (connection))
    {
      CONNECTION_UNLOCK (connection);

      *pending_return = NULL;

      return TRUE;
    }

Reply at: https://bugs.launchpad.net/dbus/+bug/139017/comments/8

------------------------------------------------------------------------
On 2008-01-15T12:24:48+00:00 Johnp-redhat wrote:

committed, thanks

Reply at: https://bugs.launchpad.net/dbus/+bug/139017/comments/10


** Changed in: dbus
   Importance: Unknown => Medium

-- 
update-notifier crashed with SIGSEGV in dbus_connection_send_with_reply()
https://bugs.launchpad.net/bugs/139017
You received this bug notification because you are a member of Registry
Administrators, which is the registrant for D-Bus.