registry team mailing list archive

[Bug Watch Updater <590619@xxxxxxxxxxxxxxxxxx>]

Launchpad has imported 5 comments from the remote bug at
http://bugs.freedesktop.org/show_bug.cgi?id=28557.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2010-06-15T10:46:50+00:00 Simon McVittie wrote:

If a connection manager parameter's value contains '\', the number of
'\' is doubled every time accounts.cfg is written.

Reply at: https://bugs.launchpad.net/mission-
control-5/+bug/590619/comments/2

------------------------------------------------------------------------
On 2010-06-15T10:49:44+00:00 Simon McVittie wrote:

> static gchar *
> get_value (const McpAccountManager *ma,
>     const gchar *acct,
>     const gchar *key)
> {
>   McdPluginAccountManager *self = MCD_PLUGIN_ACCOUNT_MANAGER (ma);
>   return g_key_file_get_value (self->keyfile, acct, key, NULL);
                      ^^^^^^^^^
> }

but:

> static void
> set_value (const McpAccountManager *ma,
>     const gchar *acct,
>     const gchar *key,
>     const gchar *value)
> {
>   McdPluginAccountManager *self = MCD_PLUGIN_ACCOUNT_MANAGER (ma);
> 
>   if (value != NULL)
>     g_key_file_set_string (self->keyfile, acct, key, value);
                 ^^^^^^^^^^
>   else
>     g_key_file_remove_key (self->keyfile, acct, key, NULL);
> }

This is not how you do GKeyFile.

Reply at: https://bugs.launchpad.net/mission-
control-5/+bug/590619/comments/3

------------------------------------------------------------------------
On 2010-06-15T11:58:46+00:00 Simon McVittie wrote:

See attached branch.

Reply at: https://bugs.launchpad.net/mission-
control-5/+bug/590619/comments/4

------------------------------------------------------------------------
On 2010-06-15T15:46:06+00:00 Vivek-collabora wrote:

Looks right. Couldn't find any stray (_get/_set)_strings any more.

Reply at: https://bugs.launchpad.net/mission-
control-5/+bug/590619/comments/5

------------------------------------------------------------------------
On 2010-06-16T03:33:16+00:00 Simon McVittie wrote:

Fixed in git, will be in 5.5.2. Some notes for any users who've been hit
by this bug:

Working around excessively large accounts.cfg
=============================================

If one of your accounts has a parameter that contains a special
character (backslash, tab or newline), it may have made your ~/.mission-
control/accounts/accounts.cfg extremely large (multiple megabytes). This
bug exists in versions 5.5.0 and 5.5.1.

First, make sure you're running a version of MC that doesn't have this
bug (either 5.4.x, or 5.5.2 or later). To do that, install the new
version, then log out and back in (or kill the mission-control-5
process).

The best way to repair a huge accounts.cfg is to remove and re-create
the account that caused it, preferably via the normal account editing UI
in Empathy.

If the account has become so large that Empathy's account editing UI no
longer works, you can do the same via the command line, with the "mc-
tool" utility provided with Mission Control. First, list your accounts:

    mc-tool list

This will output a list of account IDs, something like:

    gabble/jabber/telepathy-user_40example_2ecom0
    haze/facebook/telepathy-user0
    idle/irc/telepathy-user0
    salut/local_xmpp/account0

You can examine an account with a command like:

    mc-tool show haze/facebook/telepathy-user0

For a typical account, you'll get a small amount of output (about 15
lines in a terminal). If you get huge numbers of backslashes instead,
the account has been affected by this bug.

You can delete an account with a command like:

    mc-tool remove haze/facebook/telepathy-user0

accounts.cfg should now reduce to a sensible size (about 15 lines per
account, which might add up to a few kilobytes if you have lots of
accounts), and you can re-create the account using Empathy.

Reply at: https://bugs.launchpad.net/mission-
control-5/+bug/590619/comments/8


** Changed in: mission-control-5
       Status: Unknown => Fix Released

** Changed in: mission-control-5
   Importance: Unknown => High

-- 
Unreasonable memory usage
https://bugs.launchpad.net/bugs/590619
You received this bug notification because you are a member of Registry
Administrators, which is the registrant for Telepathy Mission Control 5.