registry team mailing list archive

[Bug Watch Updater <199486@xxxxxxxxxxxxxxxxxx>]

Launchpad has imported 9 comments from the remote bug at
http://bugs.freedesktop.org/show_bug.cgi?id=12378.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2007-09-10T02:46:02+00:00 Zeuthen wrote:

(not sure I've filed this against the right component, please advise)

ConsoleKit [1] is used to track user desktop sessions so to work with
ConsoleKit any process used to launch these needs to poke ConsoleKit so
the session can be registered. Will attach a patch to xinit.c that does
this.

[1] : 
http://gitweb.freedesktop.org/?p=ConsoleKit.git
http://people.freedesktop.org/~david/ConsoleKit.html (a bit outdated)

Btw, this patch originated from this RH bug
https://bugzilla.redhat.com/show_bug.cgi?id=233183

Reply at: https://bugs.launchpad.net/xinit/+bug/199486/comments/0

------------------------------------------------------------------------
On 2007-09-10T02:47:24+00:00 Zeuthen wrote:

Created an attachment (id=11486)
proposed patch

Reply at: https://bugs.launchpad.net/xinit/+bug/199486/comments/1

------------------------------------------------------------------------
On 2007-09-10T07:23:27+00:00 Dbn-lists wrote:

Newer CK info here:

http://www.freedesktop.org/wiki/Software/ConsoleKit

Reply at: https://bugs.launchpad.net/xinit/+bug/199486/comments/2

------------------------------------------------------------------------
On 2007-09-10T07:26:25+00:00 Dbn-lists wrote:

Created an attachment (id=11489)
Updated patch against current git with some autotools polish

Reply at: https://bugs.launchpad.net/xinit/+bug/199486/comments/3

------------------------------------------------------------------------
On 2007-12-24T06:08:24+00:00 Julien Cristau wrote:

(In reply to comment #3)
> Created an attachment (id=11489) [details]
> Updated patch against current git with some autotools polish
> 
shouldn't you also check for dbus-1 and include <dbus/dbus.h>, since you're using dbus functions?

Reply at: https://bugs.launchpad.net/xinit/+bug/199486/comments/4

------------------------------------------------------------------------
On 2008-03-07T06:19:25+00:00 Loïc Minier wrote:

@jcristau: indeed, makes sense; it will work as is because ck-connector
requires dbus in the .pc.

Using this patch, it seems that the session isn't made the active one; after discussion with other people, one thing which might help is that ck_connector_open_session_with_parameters should be used instead of ck_connector_open_session with some parameters from:
display-device
x11-display-device
x11-display

(probably session-type, is-local, and unix-user can be set easily as
well)

Reply at: https://bugs.launchpad.net/xinit/+bug/199486/comments/5

------------------------------------------------------------------------
On 2008-03-07T08:14:46+00:00 Michael Frey wrote:

(In reply to comment #0)
> (not sure I've filed this against the right component, please advise)
> 
> ConsoleKit [1] is used to track user desktop sessions so to work with
> ConsoleKit any process used to launch these needs to poke ConsoleKit so the
> session can be registered. Will attach a patch to xinit.c that does this.
> 
> [1] : 
> http://gitweb.freedesktop.org/?p=ConsoleKit.git
> http://people.freedesktop.org/~david/ConsoleKit.html (a bit outdated)
> 
> Btw, this patch originated from this RH bug
> https://bugzilla.redhat.com/show_bug.cgi?id=233183
> 

(In reply to comment #5)
> @jcristau: indeed, makes sense; it will work as is because ck-connector
> requires dbus in the .pc.
> 
> Using this patch, it seems that the session isn't made the active one; after
> discussion with other people, one thing which might help is that
> ck_connector_open_session_with_parameters should be used instead of
> ck_connector_open_session with some parameters from:
> display-device
> x11-display-device
> x11-display
> 
> (probably session-type, is-local, and unix-user can be set easily as well)
> 

Having done more research on this and actually tried to update this
patch to use the above mentioned call (open_session_with_parameters),
this will not work.

Typically xinit is not run as a root, so the user does not have enough
permissions to create a session with parameters.

I question weather or not we should try to move this call into X?  X is
setuid root.

Reply at: https://bugs.launchpad.net/xinit/+bug/199486/comments/6

------------------------------------------------------------------------
On 2008-03-12T02:40:04+00:00 Loïc Minier wrote:

Launching the session from xinit wont work and is actually harmful;
instead we should start the ck session as an encapsulating client for
the lifetime of the session; for example if you run your X11 client
within ck-launch-session, CK should look at the DISPLAY of the calling
DBus process and will provision the DISPLAY and the VT in the new CK
session.

If however we were to merge this patch, then we wouldn't have any way to
tell CK to update its info.

Reply at: https://bugs.launchpad.net/xinit/+bug/199486/comments/11

------------------------------------------------------------------------
On 2008-03-18T13:26:49+00:00 Loïc Minier wrote:

We've merged the ck-launch-session in a Xsession snippet approach in
Ubuntu, and it works fine.

I think it's clean enough and doesn't add a dbus dependency to xinit;
also, the current patch is insufficient (as it doesn't set x11-display
etc.).

The Xsession snippet might make more sense in consolekit itself or
distro packaging but I guess it should be shipped whereever the dbus-
launch or ssh-agent snippets are shipped.

Reply at: https://bugs.launchpad.net/xinit/+bug/199486/comments/24


** Changed in: xinit
   Importance: Unknown => Medium

** Bug watch added: Red Hat Bugzilla #233183
   https://bugzilla.redhat.com/show_bug.cgi?id=233183

-- 
ConsoleKit integration
https://bugs.launchpad.net/bugs/199486
You received this bug notification because you are a member of Registry
Administrators, which is the registrant for Debian.