registry team mailing list archive
-
registry team
-
Mailing list archive
-
Message #19210
[Bug 56610] Re: Automatic search from address entry doesn't work anymore
Launchpad has imported 35 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=332668.
If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.
------------------------------------------------------------------------
On 2006-04-04T09:29:56+00:00 Neil-httl wrote:
roc changed the keyword.enabled backend in bug 331522 but we need xpfe
changes.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/0
------------------------------------------------------------------------
On 2006-04-11T12:44:12+00:00 Bugzilla-mcsmurf wrote:
*** Bug 333426 has been marked as a duplicate of this bug. ***
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/1
------------------------------------------------------------------------
On 2006-04-16T15:12:25+00:00 Jag-mozilla wrote:
*grmbl*
So, shall I just add that flag to all loadURIWithFlags calls, or do we
too wanna disable keyword loads for certain cases?
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/2
------------------------------------------------------------------------
On 2006-04-16T22:26:59+00:00 Neil-httl wrote:
It would be nice if we had a list of all callers, then we could see how
easy it would be to selectively apply the flag.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/3
------------------------------------------------------------------------
On 2006-06-05T13:39:45+00:00 Neil-httl wrote:
*** Bug 340387 has been marked as a duplicate of this bug. ***
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/4
------------------------------------------------------------------------
On 2006-07-05T12:18:16+00:00 Williamsca wrote:
Does anyone know if there is a workaround to this? This is something I
*used* to do all of the time. It's hard to believe more people aren't
complaining about this being gone.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/5
------------------------------------------------------------------------
On 2006-08-04T19:15:04+00:00 Kairo-kairo wrote:
What does this bug mean?
Without seeing what really is broken or not it's hard to decide if we should hold a release (or even an Alpha) for this...
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/6
------------------------------------------------------------------------
On 2006-08-04T19:18:24+00:00 Williamsca wrote:
This means that if you have "Enable Internet Keywords" checked in the
preferences that it doesn't work anymore. In other words, if I wanted
to search for something, I would simply type it into the location bar
and hit return and it would automatically do the search based on what I
have set for Internet Search in the preferences.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/7
------------------------------------------------------------------------
On 2006-08-04T19:58:42+00:00 Kairo-kairo wrote:
Keywords and Internet Search are two different beasts, from what I know, so I'm not sure if you are right.
And if I set a keyword "bug" for %s-based Bugzilla lookup, it works well in a branch build...
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/8
------------------------------------------------------------------------
On 2006-08-04T20:12:47+00:00 Abwillis1 wrote:
I believe this is keyword.enabled set to true in about:config is what
allowed me to search from the url bar with an enter click. It was a
much smarter search system than IE has... IE decides to search for every
blasted thing that it can't find which sucks when you just mistype a
url. Seamonkey would only search with an enter if there was a space in
the url bar (indicating it was not a url) or if the format was
keyword:search where search was the word being searched for. As I
rarely do a one word search it worked beautifully. I had thought I had
just messed up my prefs.js as I had had to specify adding that ability
expressly and didn't realize it had been regressed intentionally. I for
one would really like to see this as a blocker I am constantly getting
an error message that the input was not a valid URL (really even getting
rid of the error would be better so I didn't have to acknowledge it
before hitting the search button would be OK).
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/9
------------------------------------------------------------------------
On 2006-08-04T20:35:07+00:00 Kairo-kairo wrote:
So, if I understand you correctly and this is just about the issue that
calling up the default search engine by pressing enter in the URL bar
for any string we can't handle with other methods, this is something
that would really be great to have (I'd love it as well), but we won't
block a release for it.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/10
------------------------------------------------------------------------
On 2006-08-04T20:47:07+00:00 Williamsca wrote:
That's up to you guys, but from a general user perspective it's a
previously released feature with a configuration option that now doesn't
work - a regression.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/11
------------------------------------------------------------------------
On 2006-08-04T23:18:02+00:00 Chris Thomas (CTho) wrote:
Re-request blocking for the beta.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/12
------------------------------------------------------------------------
On 2006-08-04T23:18:53+00:00 Chris Thomas (CTho) wrote:
Reading the Firefox patch, I suspect we could make the last (new)
argument optional, default to false, and that would make the patch a lot
smaller.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/13
------------------------------------------------------------------------
On 2006-08-19T21:51:53+00:00 Kairo-kairo wrote:
I'm still not sure what this really is about and how important this is,
so putting it on 1.1b radar.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/17
------------------------------------------------------------------------
On 2006-08-20T13:58:26+00:00 Aha wrote:
KaiRo: Firefox has seperated searchbox. SeaMonkey has Location Bar with
search capability. This search is now broken. (I'm using 1.0.x releases
instead 1.1 nightly because this bug.)
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/18
------------------------------------------------------------------------
On 2006-08-20T14:27:18+00:00 Abwillis1 wrote:
Just to keep things from being confused... The search does work if you
click the search button. Previously you could type keyword:searchterm
and hit enter (or if you were entering 2 or more terms separated by
spaces you could drop the keyword: part... not sure what if anything
else caused the keyword to be assumed but it wasn't brain dead like i.e.
and try to search for mistyped urls). The search does still work but
now it requires using the Search button rather than being able to use
the enter key. Here is some information on it
http://kb.mozillazine.org/Using_keyword_searches
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/19
------------------------------------------------------------------------
On 2006-08-20T14:33:50+00:00 Kairo-kairo wrote:
That's what confuses me, because I can't remember having that working in
1.0.x - I thought this has been broken since before the SeaMoneky
project had been founded.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/20
------------------------------------------------------------------------
On 2006-08-20T15:49:14+00:00 Abwillis1 wrote:
To be honest, I am not sure when it broke... I build from Trunk and
don't know the corresponding release information. I had thought I had
just borked my prefs.js and thought I was setting it back up wrong at
first (the part I thought I was setting up wrong I didn't at first
realize wouldn't affect the issue I was seeing... I just remembered I
had to make a couple of changes to get it to work as I wanted it to
originally).
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/21
------------------------------------------------------------------------
On 2006-08-20T16:25:40+00:00 Neil-httl wrote:
Created attachment 234669
fix urlbar
open location dialog sucks, will fix later
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/22
------------------------------------------------------------------------
On 2006-08-20T17:43:18+00:00 Ajschult wrote:
Comment on attachment 234669
fix urlbar
Patch looks good. I hit bug 349419 with the patch applied, but so does
firefox, so I don't think it's our misuse of the API.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/23
------------------------------------------------------------------------
On 2006-08-20T20:47:57+00:00 Neil-httl wrote:
Created attachment 234700
fix open location dialog
requires attachment 234669
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/24
------------------------------------------------------------------------
On 2006-08-20T23:26:02+00:00 Mnyromyr wrote:
While we probably may not want to halt an alpha for this, breaking the
"enter search terms in urlbar and hit enter" feature is definitely a 1.1
blocker, imo.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/25
------------------------------------------------------------------------
On 2006-08-21T04:31:29+00:00 Ajschult wrote:
Comment on attachment 234700
fix open location dialog
>@@ -63,7 +63,7 @@ function editDocument(aDocument)
as long as you're cleaning things up :) editDocument is never called.
>-function editPage(url, launchWindow, delay)
>+function editPage(url)
xpfe's (and toolkit's!) viewsource has a ViewSourceEditPage method that
still passes 3 parameters.
OpenURLDialog in xpfe/components/xremote/src/XRemoteService.cpp also
needs updating
Are you yanking the delayed open because it's icky or something directly
related to this bug?
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/26
------------------------------------------------------------------------
On 2006-08-21T08:42:11+00:00 Neil-httl wrote:
(In reply to comment #23)
>>-function editPage(url, launchWindow, delay)
>>+function editPage(url)
>xpfe's (and toolkit's!) viewsource has a ViewSourceEditPage method that still
>passes 3 parameters.
Fixed locally.
>OpenURLDialog in xpfe/components/xremote/src/XRemoteService.cpp also needs
>updating
That sucks. How much do you want to keep OpenURLDialog? It got overlooked when I implemented openurl for suiterunner.
>Are you yanking the delayed open because it's icky or something directly
>related to this bug?
Because it's icky, and I don't really want to have to touch all the functions that it uses to make them keyword-enabled.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/27
------------------------------------------------------------------------
On 2006-08-21T23:24:54+00:00 Chris Thomas (CTho) wrote:
Comment on attachment 234669
fix urlbar
Diffing from xpfe/ has the wonderful result of making the Index: line
look like a Firefox patch.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/28
------------------------------------------------------------------------
On 2006-08-22T22:45:18+00:00 Neil-httl wrote:
Created attachment 234992
addressed review comments
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/29
------------------------------------------------------------------------
On 2006-08-23T05:01:57+00:00 Ajschult wrote:
Comment on attachment 234992
addressed review comments
patch: **** malformed patch at line 146: Index:
suite/common/openLocation.js
@@ -146,17 +129,12 @@ function editPage(url, launchWindow, del
should be
@@ -146,12 +129,7 @@ function editPage(url, launchWindow, del
?
>+++ xpfe/browser/resources/content/navigator.js 20 Aug 2006 20:35:33 -0000
>+ openDialog("chrome://communicator/content/openLocation.xul", "_blank", "chrome,modal,titlebar", params);
>+ var url = getShortcutOrURI(params.url);
getShortcutOrURI doesn't like null, so this needs to bail early if the
user cancels the dialog.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/30
------------------------------------------------------------------------
On 2006-08-23T08:35:38+00:00 Neil-httl wrote:
(In reply to comment #27)
>(From update of attachment 234992)
>patch: **** malformed patch at line 146: Index: suite/common/openLocation.js
>@@ -146,17 +129,12 @@ function editPage(url, launchWindow, del
>should be
>@@ -146,12 +129,7 @@ function editPage(url, launchWindow, del
>?
You should have seen the patch before I cut out all my other junk...
>>+++ xpfe/browser/resources/content/navigator.js 20 Aug 2006 20:35:33 -0000
>>+ openDialog("chrome://communicator/content/openLocation.xul", "_blank", "chrome,modal,titlebar", params);
>>+ var url = getShortcutOrURI(params.url);
>getShortcutOrURI doesn't like null, so this needs to bail early if the user
>cancels the dialog.
I'll make it default to "" instead.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/31
------------------------------------------------------------------------
On 2006-08-23T08:39:00+00:00 Neil-httl wrote:
Created attachment 235062
fixed patch
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/32
------------------------------------------------------------------------
On 2006-08-23T08:59:02+00:00 Neil-httl wrote:
(In reply to comment #27)
>@@ -146,17 +129,12 @@ function editPage(url, launchWindow, del
>should be
>@@ -146,12 +129,7 @@ function editPage(url, launchWindow, del
Doh, I corrected the 12 to 7 but forgot to correct the 17 to 12 :-[
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/33
------------------------------------------------------------------------
On 2006-08-23T09:16:58+00:00 Neil-httl wrote:
Fix checked in.
If anyone wants internet keywords to work anywhere else, please explain
your reasoning before reopening this bug, thanks.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/34
------------------------------------------------------------------------
On 2006-09-02T16:11:57+00:00 Neil-httl wrote:
Fixed on 1.8 branch 2 days ago but I forgot to update the keywords.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/38
------------------------------------------------------------------------
On 2006-12-15T21:15:42+00:00 Trev-moz wrote:
Removing delayedOpenTab will probably break lots of extensions.
Actually, there is even one occasion where SeaMonkey itself still tries
to use this function - gTabOpenObserver.observe() in navigator.js. This
should be fixed.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/55
------------------------------------------------------------------------
On 2007-07-09T05:41:39+00:00 Benc-meer wrote:
V/fixed.
Seamonkey 1.1.2, macosx10.4.
Reply at: https://bugs.launchpad.net/epiphany/+bug/56610/comments/76
** Changed in: firefox
Importance: Unknown => Medium
--
Automatic search from address entry doesn't work anymore
https://bugs.launchpad.net/bugs/56610
You received this bug notification because you are a member of Registry
Administrators, which is the registrant for Epiphany.
