registry team mailing list archive
-
registry team
-
Mailing list archive
-
Message #19217
[Bug 187313] Re: [MASTER] right click (with button release) might activate random popup-menu-item
Launchpad has imported 24 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=312225.
If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.
------------------------------------------------------------------------
On 2005-10-12T20:58:35+00:00 Unixgabe wrote:
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.12) Gecko/20051004 Firefox/1.0.7
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.12) Gecko/20051004 Firefox/1.0.7
If you right click in a browser window a context menu normally appears.
However, if you right click in the bottom-right area of the screen(not just
browser), so that the context menu appears above, and not fully to the right of
the curser, the context menu appears breifly and the bottom-most menu item is
selected. This seems to be because when you release the right-click, the curser
is actually over the last menu item, and the context menu registers this as a
mouse click release.
Reproducible: Always
Steps to Reproduce:
1. Move mouse to bottom-right corner of screen (must be screen, not just browser
window)
2. Right-click and release.
3.
Actual Results:
Context menu briefly appeard and disapeared. Last menu option was activated, in
this case the "Page Info" window was displayed.
Expected Results:
Context menu should have remained until an option was selected or I clicked
outside of context menu.
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/0
------------------------------------------------------------------------
On 2005-10-14T17:24:01+00:00 Brettw-gmail wrote:
I couldn't reproduce this on Windows (2005 Oct 13 trunk and 1.5b2) or on my
version of Linux with similar versions. If I click on the exact corner, the menu
appears slightly to the left of the mouse. If I click near the corner, the menu
is aligned with the bottom of the screen (and hence, the mouse), but the border
of the menu doesn't count as the menu.
Could this be theme related on your Linux system?
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/1
------------------------------------------------------------------------
On 2006-02-13T17:40:43+00:00 Trev-moz wrote:
This should be filed under Core - XP Toolkit/Widgets: Menus
Tweaking product and component...
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/2
------------------------------------------------------------------------
On 2006-02-13T17:55:18+00:00 Trev-moz wrote:
I got a report (http://bugzilla.mozdev.org/show_bug.cgi?id=13196) that
this happens in Firefox 1.5.0.1 on Linux with the default theme. I can't
confirm this however, for me the context menu works fine (Firefox
1.5.0.1 on KDE).
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/3
------------------------------------------------------------------------
On 2006-02-13T22:53:31+00:00 Nickers wrote:
I can reproduce this bug on Gnome 2.12.2 with default settings (Metacity
+ Clearlooks). The bug seems to be caused by the fact, that the edge of
context menu is always positioned a few pixels to the bottom-right from
the mouse pointer. I suggest this to be changed, so the pointer is a few
pixels _away_ from the menu.
The bug is also present in the current nightly [Mozilla/5.0 (X11; U;
Linux i686 (x86_64); en-US; rv:1.9a1) Gecko/20060213 Firefox/1.6a1].
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/4
------------------------------------------------------------------------
On 2006-04-22T02:03:58+00:00 Bzbarsky wrote:
So... I can't seem to reproduce this. roc, can you reproduce?
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/5
------------------------------------------------------------------------
On 2006-04-26T02:50:21+00:00 Roc-ocallahan wrote:
Nope. The cursor is in the menu, but I have to move it a pixel or three
upwards before an item is selected.
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/6
------------------------------------------------------------------------
On 2006-04-26T02:58:49+00:00 Bzbarsky wrote:
Hmm.. For me it's not even in the menu; it really shouldn't be in the
menu....
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/7
------------------------------------------------------------------------
On 2007-03-10T14:02:01+00:00 Florian-queze wrote:
*** Bug 333789 has been marked as a duplicate of this bug. ***
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/8
------------------------------------------------------------------------
On 2007-03-10T14:46:57+00:00 Florian-queze wrote:
I can reproduce this on Ubuntu 6.10 with a current trunk build.
(Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a3pre) Gecko/20070222 Minefield/3.0a3pre)
When I open the context menu, the cursor is over the last item and it opens Page Info when I release the button.
I need to move the cursor one pixel upwards to get the highlight on the last menu item.
If I move the cursor at least one pixel downwards before releasing the button, the menu stays open.
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/9
------------------------------------------------------------------------
On 2008-01-29T20:36:45+00:00 Jakub 'Livio' Rusinek wrote:
It has not been fixed until three years?! Nice...
CC'ing myself.
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/10
------------------------------------------------------------------------
On 2008-04-19T13:16:51+00:00 Roc-ocallahan wrote:
Created attachment 316582
fix
Here's my fix. The problem is that the context menu code tries to move
the menu two pixels down and to the right so that the menu does not
appear under the cursor. But sometimes --- when you're near the bottom
right of the screen --- nsMenuPopupFrame decides to place the context
menu above the designated position; in that case, moving the menu down
two pixels was wrong, we actually need to move the menu up two pixels.
So this patch passes the 2-pixel offset down as a parameter to
nsMenuPopupFrame, which can use that information to place the popup
correctly if it decides to make it appear above the mouse position.
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/31
------------------------------------------------------------------------
On 2008-04-19T22:41:48+00:00 Enn wrote:
Seems like it would be easier to just add the 2 pixels in
nsMenuPopupFrame::SetPopupPosition as needed when mIsContextMenu is true
instead.
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/32
------------------------------------------------------------------------
On 2008-04-20T23:31:19+00:00 Roc-ocallahan wrote:
That would change the behaviour of nsPopupBoxObject::OpenPopupAtScreen.
If that's OK with you, I'll do that.
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/33
------------------------------------------------------------------------
On 2008-04-22T00:06:19+00:00 Roc-ocallahan wrote:
Created attachment 316915
fix v2
Okay, fixed as described.
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/37
------------------------------------------------------------------------
On 2008-04-22T20:04:29+00:00 Enn wrote:
Comment on attachment 316915
fix v2
>-nsMenuPopupFrame::InitializePopupAtScreen(PRInt32 aXPos, PRInt32 aYPos)
>+nsMenuPopupFrame::InitializePopupAtScreen(PRInt32 aXPos, PRInt32 aYPos,
>+ PRBool aIsContextMenu)
> {
> EnsureWidget();
>
> mPopupState = ePopupShowing;
> mAnchorContent = nsnull;
> mScreenXPos = aXPos;
> mScreenYPos = aYPos;
> mPopupAnchor = POPUPALIGNMENT_NONE;
> mPopupAlignment = POPUPALIGNMENT_NONE;
>+ mIsContextMenu = aIsContextMenu;
>+ mAdjustOffsetForContextMenu = aIsContextMenu;
mAdjustOffsetForContextMenu should be set to false for the other two
InitializeX methods.
> screenViewLocY = nsPresContext::CSSPixelsToAppUnits(mScreenYPos) / factor;
>+ PRInt32 offsetForContextMenuCSS = mAdjustOffsetForContextMenu ? 2 : 0;
>+ PRInt32 offsetForContextMenuDev =
>+ nsPresContext::CSSPixelsToAppUnits(offsetForContextMenu) / factor;
You meant 'offsetForContextMenuCSS' here right?
I assume with this patch that the test for contextmenus
(test_contextmenu_list.xul) works ok?
I'm not a superreviewer, so let's ask the other Neil.
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/38
------------------------------------------------------------------------
On 2008-04-22T22:38:17+00:00 Roc-ocallahan wrote:
Created attachment 317116
fix v3
Updated to comments.
test_contextmenu_list.xul passes on my Mac.
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/39
------------------------------------------------------------------------
On 2008-04-23T08:45:52+00:00 Neil-httl wrote:
Comment on attachment 317116
fix v3
>+ nscoord offsetForContextMenu = 0;
>+ PRInt32 offsetForContextMenuCSS = mAdjustOffsetForContextMenu ? 2 : 0;
>+ PRInt32 offsetForContextMenuDev =
>+ nsPresContext::CSSPixelsToAppUnits(offsetForContextMenuCSS) / factor;
>+ offsetForContextMenu = presContext->DevPixelsToAppUnits(offsetForContextMenuDev);
Any reason not to do this in an if rather than possibly calculating with zero?
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/41
------------------------------------------------------------------------
On 2008-04-23T08:51:11+00:00 Roc-ocallahan wrote:
I guess it's about as simple to put the whole thing in an "if", sure,
I'll do that.
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/42
------------------------------------------------------------------------
On 2008-04-23T08:53:35+00:00 Roc-ocallahan wrote:
Comment on attachment 317116
fix v3
Fixes a pretty bad Linux usability issue where we fire random context
menu commands in some situations (I think it's a regression). May also
fix or at least narrow down blocker bug 404314. Rather safe fix too, I
think.
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/43
------------------------------------------------------------------------
On 2008-04-23T10:38:13+00:00 Beltzner wrote:
Comment on attachment 317116
fix v3
a1.9=beltzner
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/44
------------------------------------------------------------------------
On 2008-04-23T21:25:56+00:00 Roc-ocallahan wrote:
Checked in.
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/45
------------------------------------------------------------------------
On 2008-07-02T17:10:49+00:00 Vseerror wrote:
*** Bug 370920 has been marked as a duplicate of this bug. ***
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/111
------------------------------------------------------------------------
On 2009-07-09T12:14:29+00:00 Roman Polach wrote:
I sometimes still see this problem in 3.5 (windows)
although in much less frequency than in 3.0.9...
Reply at: https://bugs.launchpad.net/firefox/+bug/187313/comments/299
** Changed in: firefox
Importance: Unknown => Medium
** Bug watch added: Mozdev Bugzilla #13196
https://www.mozdev.org/bugs/show_bug.cgi?id=13196
--
[MASTER] right click (with button release) might activate random popup-menu-item
https://bugs.launchpad.net/bugs/187313
You received this bug notification because you are a member of Registry
Administrators, which is the registrant for Fedora.
