← Back to team overview

registry team mailing list archive

[Bug 37828] Re: Text rendered incorrectly in presence of ligatures and justified text

 

Launchpad has imported 23 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=331716.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2006-03-25T21:00:07+00:00 Karl Hegbloom wrote:

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060314 Ubuntu/dapper Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060314 Ubuntu/dapper Firefox/1.5.0.1

When certain fonts are chosen, the ligatures for 'fi' and 'fl' appear
too close to the following letter.  Sometimes, for words like "file",
the "i" completely disappears.  The fonts I noticed it with are the
'sans-serif' (generic, chosen by the fontconfig system, afaiui; default
Ubuntu 'Dapper'), and 'Dejavu Sans'.  When I switch to 'Verdana', there
are no ligatures, so the problem does not manifest.

Reproducible: Always



I will attach screenshots.

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/0

------------------------------------------------------------------------
On 2006-03-25T21:00:59+00:00 Karl Hegbloom wrote:

Created attachment 216243
Showing the 'fi' ligature.

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/1

------------------------------------------------------------------------
On 2006-03-25T21:01:37+00:00 Karl Hegbloom wrote:

Created attachment 216244
Showing the 'fl' ligature.

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/2

------------------------------------------------------------------------
On 2006-03-26T15:21:22+00:00 Bugzilla-tecnocode wrote:

Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a1) Gecko/20060325 Firefox/1.6a1 - Build ID: 0000000000
Works for me with Dejavu Sans.
What font-size have you set it to, and does anything change if you press Ctrl+0? (That's a zero.)

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/3

------------------------------------------------------------------------
On 2006-04-03T06:56:49+00:00 James Henstridge wrote:

I reported this in Launchpad (the Ubuntu bug tracker) here:
    https://launchpad.net/distros/ubuntu/+source/firefox/+bug/37828

The conditions necessary to trigger it are:
 * using Pango for font rendering (the default with the Ubuntu Dapper packages).
 * using a font with ligatures (e.g. DejaVu Sans -- the default sans-serif
   font for Ubuntu Dapper).
 * using "text-align: justify" or equivalent markup to get justified text.

It seems that the ligature glyph is drawn, but the advance of standard
glyph for the first character is used, resulting in later characters
being rendered over the top of the ligature.

I am not sure if this is an Ubuntu-only bug yet.  It would be
interesting to hear if people not using Ubuntu are able to reproduce the
bug, when the above conditions are met.

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/9

------------------------------------------------------------------------
On 2006-04-03T18:06:08+00:00 Robin Munn wrote:

Based on the comments at James Henstrige's blog post,
http://blogs.gnome.org/view/jamesh/2006/04/03/0, it seems his question
has been answered. People are seeing this on Debian (both in Firefox and
Epiphany), OS X, FreeBSD, Mandriva, Gentoo... Looks like it's not
distro-specific.

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/18

------------------------------------------------------------------------
On 2006-04-05T13:33:58+00:00 Vincent+moz wrote:

I also see this on Debian with the recent builds (which use pango).
Could this bug be confirmed and the subject changed to:

'fi' and 'fl' ligatures too close to following letter in justified text
when Pango is enabled

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/20

------------------------------------------------------------------------
On 2006-04-11T13:01:14+00:00 James Henstridge wrote:

As Vincent says, this bug is not an Ubuntu only bug.  It is just easier
to hit on Ubuntu Dapper than other systems.

The prerequisites are:
 1. A Firefox build with pango enabled.
 2. Pango 1.12, which is the first version to use OpenType tables for
    rendering latin text.
 3. A font that contains OpenType ligature table entries, such as DejaVu (the
    Bitstream Vera fonts contain some ligature glyphs but not the associated
    OpenType tables that trigger their use by Pango).

The bug will then present itself on pages where the following hold:
 1. The page requests one of the affected fonts (if an affected font is the
    default serif or sans serif font, then this can be quite common).
 2. The page must trigger the slow manual glyph placement code path, which
    is used in the presence of non-default character or word spacing.  The
    "text-align: justify" CSS rule is one way to do this.

The bug has been observed with Firefox 1.5.0.1.  In the Launchpad bug,
one person posted a screenshot showing that Firefox 1.6a1 did not seem
to be affected by the bug.  I have not verified this personally though.

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/22

------------------------------------------------------------------------
On 2006-04-14T01:31:31+00:00 Bugzilla-dolphinling wrote:

*** Bug 331694 has been marked as a duplicate of this bug. ***

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/23

------------------------------------------------------------------------
On 2006-04-18T03:51:18+00:00 Roc-ocallahan wrote:

I don't recommend using the existing Pango code. It's a hack started by
Red Hat. It should really not be enabled by distributions except for
locales where it's really needed (mostly Indic users).

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/32

------------------------------------------------------------------------
On 2006-04-18T06:46:17+00:00 James Henstridge wrote:

Surely the Pango code is needed to correctly display the affected
languages/scripts in any locale.  That'd be why the distributions choose
to use the Pango build instead.

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/33

------------------------------------------------------------------------
On 2006-04-18T08:48:09+00:00 Roc-ocallahan wrote:

For languages without complex script requirements, the non-Pango code is
quite adequate. This includes European languages, most East Asian
languages (CJK), and Hebrew. As far as I know, only Indic languages and
Arabic (including Persian/Farsi) really benefit from the Pango path.

We are now working on full Pango integration but this won't be ready for
quite some time.

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/34

------------------------------------------------------------------------
On 2006-04-19T07:50:50+00:00 James Henstridge wrote:

What I was getting at is that a distro might want to be able to display
more scripts than just the user's chosen locale (e.g. Ubuntu includes
fonts for many different scripts in the default install).  From this
point of view, having Indic/Arabic text display correctly in non
Indic/Arabic locales is desirable (especially in the web browser).

There is one modification to my steps to reproduce the bug: if using
DejaVu to reproduce the bug, you must use a version < 2.5.  The latest
version doesn't include "liga" table entries for the ligatures in
question, so the bug is not triggered (it seems that the change to the
font was made because of this bug).

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/39

------------------------------------------------------------------------
On 2006-04-19T08:23:56+00:00 Roc-ocallahan wrote:

(In reply to comment #12)
> What I was getting at is that a distro might want to be able to display more
> scripts than just the user's chosen locale (e.g. Ubuntu includes fonts for
> many different scripts in the default install).  From this point of view,
> having Indic/Arabic text display correctly in non Indic/Arabic locales is
> desirable (especially in the web browser).

It certainly is desirable! and we're working on it. It's just that with
FF1.5/2 that requires some fairly nasty tradeoffs.

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/40

------------------------------------------------------------------------
On 2006-04-19T09:04:19+00:00 Jshin1987 wrote:

(In reply to comment #11)
> For languages without complex script requirements, the non-Pango code is quite
> adequate. This includes European languages, most East Asian languages (CJK),
> and Hebrew. As far as I know, only Indic languages and Arabic (including
> Persian/Farsi) really benefit from the Pango path.

As the 0th or even 1st-order approximation, what you wrote above is more
or less right, but it's not that simple. See bug 215219 comment #97.
Korean has complex script requirements (unfortunately, Pango's Korean
support is inferior to that of ours because my patch to Pango a few
years ago never got merged). So do Hebrew, Latin, and Greek.

(In reply to comment #13)

> It certainly is desirable! and we're working on it. It's just that with FF1.5/2
> that requires some fairly nasty tradeoffs.

In retrospect, my dirty hack in bug 215219 might have been an acceptable
compromise for ff 1.5. With that, MathML still works well, Arabic/Hebrew
work decently, and there's little performance loss for "non-complex"
scripts.

BTW, the version field for this bug is set to 1.0branch, but that's not
quite right given that ff 1.0 (gecko 1.7branch) branch does not contain
blizzard's patch for bug 214715. RedHat and other distros ported the
patch to ff 1.0 and still includes FF 1.0 instead of 1.5 (even Fedora
Core 5 has 1.0.x whose PS printing module is not so good because bug
234182 was not fixed for FF1.0/Gecko 1.7). In our tree, it's not until
gecko 1.8 that his patch was incorporated.


Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/41

------------------------------------------------------------------------
On 2006-07-28T09:23:57+00:00 5-admin-globalcurves-com wrote:

You can easily see this bug by going to google and searching for
anything:

Here's and example:
http://www.google.com/search?hl=en&lr=&q=Mozilla+Firefox&btnG=Search

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/54

------------------------------------------------------------------------
On 2007-05-30T20:36:23+00:00 Keenan Pepper wrote:

What's the status of this bug? Has anyone been working on it?

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/59

------------------------------------------------------------------------
On 2007-05-31T18:19:38+00:00 Jmdesp wrote:

This problem should be solved with the new textframe code. This code
will be turned on in the Fx nightlies very soon, many at the start of
next week.

Roc has indicated that he is taking into account the problem on his blog
http://weblogs.mozillazine.org/roc/archives/2007/05/the_glyph_bound.html,
and there are patches being developed to be sure it works in all cases
http://weblogs.mozillazine.org/roc/archives/2007/05/things_ive_seen.html

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/60

------------------------------------------------------------------------
On 2008-08-21T18:05:52+00:00 Ahangama wrote:

The screenshots given with the original report shows as if the font
maker forgot to adjust the Advance Width if the ligature glyph leaving
it at the width used by the first letter of the combination. If this
theory is correct, there is nothing that Mozilla should do.

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/100

------------------------------------------------------------------------
On 2008-08-21T18:15:23+00:00 Ben Laenen wrote:

(In reply to comment #18)
> The screenshots given with the original report shows as if the font maker
> forgot to adjust the Advance Width if the ligature glyph leaving it at the
> width used by the first letter of the combination. If this theory is
> correct, there is nothing that Mozilla should do.

It's already determined long ago that the bug was in Mozilla, and it has
been fixed in Firefox 3.0.

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/101

------------------------------------------------------------------------
On 2008-08-21T22:07:54+00:00 Roc-ocallahan wrote:

Right, this is a 1.8 branch bug, i.e. Firefox 2 only.

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/102

------------------------------------------------------------------------
On 2008-08-25T09:26:32+00:00 Jmdesp wrote:

IMO there's no reason to keep this open and we should WONTFIX it, as 
- there's nobody strongly willing to take this bug and fix it in Firefox 2.
- even if there was someone willing to do that, I believe such a patch would have no chance of getting into the 2 branch which is now open about only for security fixes, right ?


Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/103

------------------------------------------------------------------------
On 2008-08-25T09:30:01+00:00 Roc-ocallahan wrote:

WONTFIX may not be technically correct, but I'd certainly like to
discourage anyone from wasting their time on this, so ... WONTFIX.

Reply at: https://bugs.launchpad.net/firefox/+bug/37828/comments/104


** Changed in: firefox
   Importance: Unknown => Medium

-- 
Text rendered incorrectly in presence of ligatures and justified text
https://bugs.launchpad.net/bugs/37828
You received this bug notification because you are a member of Registry
Administrators, which is the registrant for Debian.