registry team mailing list archive

[Ewan Mellor <654025@xxxxxxxxxxxxxxxxxx>]

On Mon, Oct 04, 2010 at 07:44:15PM +0100, Soren Hansen wrote:

> I just did a quick grep through the source code for project_get_network.
> I stopped counting when I had found 10 uses of it that would fail if it
> got back None or an execption (and only 1 that handled it gracefully).
> 
> What about those?

What to do about other calls to project_get_network is a question for those
call-sites.  It might well be perfectly reasonable for the NotFound
exception to propagate up to a higher layer in those cases.  I'm not
advocating catching exceptions at every call-site -- that's not what exceptions
are for.

My patch catches one exception at the very top level (nova-manage), and one at
a call-site that was already set up to gracefully handle missing VPN
information.

-- 
nova-manage project zip and nova-manage vpn list broken by change in DB semantics when networks are missing
https://bugs.launchpad.net/bugs/654025
You received this bug notification because you are a member of Registry
Administrators, which is subscribed to OpenStack.