registry team mailing list archive

[Soren Hansen <soren@xxxxxxxxxx>]

On 05-10-2010 18:53, Ewan Mellor wrote:
> On Mon, Oct 04, 2010 at 07:11:26PM +0100, Soren Hansen wrote:
>> If you change nova-manage to simply ignore it when it comes across data
>> the violates our currently expected data model, you're just delaying the
>> catastrophe until another part of the code comes across and tries to
>> handle this data. nova-manage is the only UI nova has, so it's the best
>> place imaginable to be notified about these things.
> I didn't change nova-manage to "simply ignore it" -- it prints None.  I'm
> quite happy to print "Warning warning danger danger" if you want, if you
> think that this really does violate the expected datamodel.  Exploding
> isn't acceptable though -- debugging is a lot harder if the tools just throw
> a backtrace instead of diagnosing the problem for you.  I agree that you
> should be notified about this problem by nova-manage.  I don't agree that
> a backtrace is an acceptable way to do that.

I never said the output should be a backtrace. I'm saying that masking
an *actual* error in the UI, completely ignoring it and covering it up,
is not ok. However, that's exactly what you're doing by making the UI
just say "None" when it really means "None (which is not valid, so do
not expect this project to be able to do anything at all and expect to
have to do all sort of manual cleanup when the backend fails in
spectacular ways when trying to deal with this project)".

Really, it's not that hard. Either we merge Vishy's branch that creates
the network on the fly if it doesn't exist once it's requested (by far
the preferred approach), or we change nova-manage to fix it when it
encounters this problem (as a last resport.. well, second to last
resort. Masking the error should be last resort and we're not quite in
last resort territory yet).

Once Vishy's branch is merged, nova-manage should probably say "Not
assigned yet" rather than "None", though, but that's a slightly
different story.

-- 
Soren Hansen
Ubuntu Developer    http://www.ubuntu.com/
OpenStack Developer http://www.openstack.org/

-- 
nova-manage project zip and nova-manage vpn list broken by change in DB semantics when networks are missing
https://bugs.launchpad.net/bugs/654025
You received this bug notification because you are a member of Registry
Administrators, which is subscribed to OpenStack.