rohc team mailing list archive

[Didier Barvaux <didier.barvaux@xxxxxxxxxxxxxxxxxxxx>]

Josephine,

> I'm trying to test the statistics tool in rohc-1.2.0. Running
> 
>     $auto.pl
> 
> generated this error:
> 'Use of uninitialized value in addition (+) at ./stats.pl line 249,
> <PACKETS_SIZE> line 1'
> 
> [...]
> 
> Can anyone help out with this? I'm using Ubuntu 8.0.4.

I confirm the problem you encounter. I didn't test this tool for a long
time. I opened a bug to track the problem. You can consult it at:
https://bugs.launchpad.net/rohc/trunk/+bug/409562

I committed a fix in the 1.2.x branch.

To get the fix, you can either apply the attached patch on release
1.2.0 or download the source code from the Bazaar repository:
https://code.launchpad.net/~didier-barvaux/rohc/1.2.x

If you use the attached patch, you have to manually change the
permissions of some scripts:
 $ chmod a+x statistics/analyse_log.pl statistics/auto.pl
 $ chmod a+x statistics/gnuplot.sh statistics/stats.pl
 $ chmod a+x statistics/test.sh

Let me known if it does not fix your problem.

Didier Barvaux
Viveris Technologies

=== modified file '.bzrignore'
--- .bzrignore	2009-08-04 16:04:51 +0000
+++ .bzrignore	2009-08-05 21:37:33 +0000
@@ -4,6 +4,7 @@
 .libs
 *.lo
 *.la
+log.xml
 ./cscope.out
 ./aclocal.m4
 ./autom4te.cache
@@ -25,3 +26,11 @@
 ./test/test
 ./test/report/report.html
 ./app/tunnel/rohctunnel
+./statistics/header_size.png
+./statistics/headers_size
+./statistics/list.txt
+./statistics/packet_type
+./statistics/packets_order
+./statistics/packets_size
+./statistics/packets_size.png
+./statistics/stats.html

=== modified file 'INSTALL'
--- INSTALL	2009-08-04 15:03:33 +0000
+++ INSTALL	2009-08-05 21:11:20 +0000
@@ -88,16 +88,19 @@
 Test and Statistic tool
 -----------------------
 
-1. Go to the subdirectory
+1. Be sure to the library is built. If not, follow the instructions given at
+   the beginning of this file.
+
+2. Go to the subdirectory
 
  $ cd statistics
 
-2. Execute the script
+3. Execute the script
 
  $ ./auto.pl
 
 Answer questions of the script (number of tests...)
 
-3. Load the ./statistics/stats.html file in your favorite browser and watch the
+4. Load the ./statistics/stats.html file in your favorite browser and watch the
    results.
 

=== modified file 'statistics/analyse_log.pl' (properties changed: -x to +x)
--- statistics/analyse_log.pl	2007-07-06 13:17:14 +0000
+++ statistics/analyse_log.pl	2009-08-06 09:50:41 +0000
@@ -1,6 +1,7 @@
 #!/usr/bin/perl -w
 #
 # Author: David Moreau from TAS
+# Author: Didier Barvaux <didier.barvaux@xxxxxxxxxxxxxxxxxxxx>
 #
 
 
@@ -97,7 +98,7 @@
 		if($nb_tests==1) { # in order to analyse only the first test
 
 			#extraction of packets size
-			$i = index($line2,'Size of IP packet');
+			$i = index($line2, 'size of IP packet');
 			if($i > 0 && $bool == 1) {
 				@t = split(' ',$line2);
 				$indice = 0;

=== modified file 'statistics/auto.pl' (properties changed: -x to +x)
=== modified file 'statistics/gnuplot.sh' (properties changed: -x to +x)
=== modified file 'statistics/list_all.txt'
--- statistics/list_all.txt	2007-07-06 13:17:14 +0000
+++ statistics/list_all.txt	2009-08-05 21:23:18 +0000
@@ -6,7 +6,7 @@
 ipv4/udp/rtp/video2
 ipv4/udp/rtp/video3
 ipv4/udp/rtp/rtp_rtp_icmp
-ipv4/udp/rtp/divers
+ipv4/udp/rtp/misc
 ipv4fragmented
 ipv4/icmp
 ipv4/icmp+tcp

=== modified file 'statistics/stats.pl' (properties changed: -x to +x)
=== modified file 'statistics/test.sh' (properties changed: -x to +x)
--- statistics/test.sh	2007-07-06 13:17:14 +0000
+++ statistics/test.sh	2009-08-06 09:50:21 +0000
@@ -1,20 +1,21 @@
 #!/bin/sh
 #
 # Author: David Moreau from TAS
+# Author: Didier Barvaux <didier.barvaux@xxxxxxxxxxxxxxxxxxxx>
 #
 
-EXEC="../test/test"
-PATH="../test/report/samples/"
+TEST_EXEC="../test/test"
+SAMPLES_PATH="../test/report/samples/"
 
 while read aLine
 do
 	echo -en $aLine" ..... \e[31m"
-	$EXEC $PATH$aLine"/source.pcap" -o $PATH$aLine"/rohc.pcap"> $PATH$aLine"/log.xml"
+	$TEST_EXEC "$SAMPLES_PATH$aLine/source.pcap" > "$SAMPLES_PATH$aLine/log.xml"
 	if [ "$?" = 0 ]
 	then
 		echo -e "\e[32m OK"
 	fi
 	echo -ne "\e[m"
-	#/bin/rm -f $PATH$aLine"/log.xml"
+	#/bin/rm -f $SAMPLES_PATH$aLine"/log.xml"
 done