rohc team mailing list archive

[Cédric Baudoin <question86663@xxxxxxxxxxxxxxxxxxxxx>]

Question #86663 on rohc changed:
https://answers.launchpad.net/rohc/+question/86663

    Status: Open => Answered

Cédric Baudoin proposed the following answer:
Thank you very much for your precise code review 
You're right : in the case of UO0 packets, the CRC is calculated taking into account the complete IP header

in comp/c_generic.c:
f_byte |= crc_calculate(CRC_TYPE_3, ip_get_raw_data(ip), ip_get_hdrlen(ip) +
                                (nr_of_ip_hdr > 1  ? ip_get_hdrlen(ip2) : 0) +
                                g_context->next_header_len);

since ip_get_raw_data points to the original IP header

This does not change the behavior of the compression/decompression, but will affect
1- the performance (the computation complexity is slightly lower following the guidelines)
2- interoperability (the CRC calculated by the compressor of ROHC lib will be different from an other ROHC implementation)

Are you interested to submit a patch ?

-- 
You received this question notification because you are a member of ROHC
Team, which is an answer contact for rohc.