rohc team mailing list archive

[Didier Barvaux <didier@xxxxxxxxxxx>]

FWX,

>   While adding TCP source files in current branch, I have some
> problems with last changes made in d_generic_context...
> 
>   Can you help me with these errors:
> 
> d_tcp.c: In function ‘d_tcp_create’:
> d_tcp.c:191: error: ‘struct d_generic_context’ has no member named 
> ‘decode_uo_tail’

Renamed to parse_uo_remainder() because the function does parsing
and not decoding, and because the word 'remainder' is used in RFC
instead of 'tail'.


> d_tcp.c:199: error: ‘struct d_generic_context’ has no member named
> ‘last1’
> d_tcp.c:210: error: ‘struct d_generic_context’ has no member named
> ‘last2’

I reworked the way the decompressor parsed and decoded packets. Now,
the packet is parsed and its fields are decoded without altering the
decompression context. This is important in order the context to be
unchanged if the CRC check fails.

The previous code was performing its changes in a copy of the
context (last1 for outer IP header, last2 for inner IP header),
that was synchronized with the real context (active1/active2)
once the CRC was checked OK. During the code reworking, the last1 and
last2 variables were not needed anymore, so I removed them.

active1 and active2 variables were renamed to outer_ip_changes and
inner_ip_changes. The word 'active' was not very clear once the 'last'
variables were removed.


> d_tcp.c:357: error: ‘struct d_generic_context’ has no member named
> ‘current_packet_time’
> d_tcp.c:357: warning: implicit declaration of function
> ‘get_microseconds’

current_packet_time and the related get_microseconds() were dead code.


Regards,
Didier