rohc team mailing list archive

[Didier Barvaux <question229448@xxxxxxxxxxxxxxxxxxxxx>]

Question #229448 on rohc changed:
https://answers.launchpad.net/rohc/+question/229448

    Status: Open => Answered

Didier Barvaux proposed the following answer:
I changed it in the main branch after the 1.5.0 release (so it only
appears in next 1.6.0). Value 10 was too short in case of bursts of
decompression errors and therefore bursts of feedbacks.

For this kind of questions, the source revision system got the answer:

  $ bzr branch lp:rohc rohc-main
  $ cd rohc-main
  $ bzr blame src/comp/rohc_comp_internals.h | grep FEEDBACK_RING_SIZE | grep define
  568 didier@ | #define FEEDBACK_RING_SIZE 1000

  $ bzr log -r 568
  ------------------------------------------------------------
  revno: 568
  committer: Didier Barvaux <HIDDEN_EMAIL>
  branch nick: rohc-main
  timestamp: Sat 2012-11-17 10:58:33 +0100
  message:
    Increase default feedback ring size.
  modified:
    src/comp/rohc_comp_internals.h

  $ bzr diff -r 567..568
  === modified file 'src/comp/rohc_comp_internals.h'
  --- src/comp/rohc_comp_internals.h	2012-11-11 20:16:44 +0000
  +++ src/comp/rohc_comp_internals.h	2012-11-17 09:58:33 +0000
  @@ -42,7 +42,7 @@
   #define C_NUM_PROFILES 6
   
   /** The maximal number of outgoing feedbacks that can be queued */
  -#define FEEDBACK_RING_SIZE 10
  +#define FEEDBACK_RING_SIZE 1000
   
   /** Print a debug trace for the given compression context */
   #define rohc_comp_debug(context, format, ...) \


Regards,
Didier

-- 
You received this question notification because you are a member of ROHC
Team, which is an answer contact for rohc.