← Back to team overview

sapidlib-dev team mailing list archive

Re: Fwd: Added new functions to TERMINAL_D

 

2008/7/3 Cody A.W. Somerville <cody-somerville@xxxxxxxxxx>:
> Ever heard of SRP?
No. Having never studied OOP&D, I wouldn't have a clue. SRP to me
means Suggested Retail Price, in fact to 99% of the people in the UK
it means that.

It took me 20 minutes for me to track it down on Google. It seems that
everyone just uses the acronym and expects everyone else to understand
what it stands for.

> This is a clear violation and compromises the cohesion of
> the mudlib. If you want to get the user's type type, you don't call
> TERMINAL_D, passing it the object so that the TERMINAL_D can make a call on
> it and return a value... you call the function directly in the user object.
...of which NPC's also use. I've witnessed what happens when an NPC
outputs a long line to the screen, it formats it for a default width
of 80 for *everyone*.

The reason I placed it into terminal_d was because it was far easier
to implement it that way.

Secondly this is the whole point of a revision system. Code evolves
over time. If we were to agonise over where each piece of code should
go, nothing would be done. It would get bogged down in pointless
committee meetings.

When I've finished converting all the format_mixed() code back to
(s)printf() I'll have a look at it.

-- 
Richard Harrison
East Bierley Cricket Club *Committee* member



Follow ups

References