sapidlib-dev team mailing list archive

["Richard Thomas Harrison" <harrison.rt@xxxxxxxxx>]

2008/7/8 Cody A.W. Somerville <cody-somerville@xxxxxxxxxx>:
>
>
> On Mon, Jul 7, 2008 at 4:57 AM, <noreply@xxxxxxxxxxxxx> wrote:
>>
>> ------------------------------------------------------------
>> revno: 77
>> committer: Richard Harrison <harrison.rt@xxxxxxxxx>
>> branch nick: dev
>> timestamp: Mon 2008-07-07 08:54:08 +0100
>> message:
>>   * Fixed a typo (missing comma for an argument list) in mod_mudlist.c
>>   * Increased the maximum string length and readfile lengths to cope with
>>     big history files. Very rare.
>> modified:
>>  etc/config.lpu
>>  lib/adm/daemons/chmodules/i3services/mod_mudlist.c
>>
>> === modified file 'etc/config.lpu'
>> --- a/etc/config.lpu    2008-06-30 15:10:24 +0000
>> +++ b/etc/config.lpu    2008-07-07 07:54:08 +0000
>> @@ -88,10 +88,10 @@
>>  inherit chain size : 30
>>
>>  # maximum length of a string variable
>> -maximum string length : 200000
>> +maximum string length : 500000
>>
>>  # Max size of a file allowed to be read by 'read_file()'.
>> -maximum read file size : 200000
>> +maximum read file size : 500000
>>
>>  # max number of bytes you allow to be read and written with read_bytes
>>  # and write_bytes
>
> This change is rather dangerous. When I was developing the alias daemon, I
> had these values increased and it resulted in memory corruption and other
> nasties when doing more complex string operations. Instead of blindly
> increasing these values, the history files should be buffered (ie. only read
> in the amount that you need at a time) or split them up. However, it doesn't
> appear you increased the values as much as I had so this increase may be
> fine.

Rock the Halo has been running on those values for nearly 2 years.

The one value that is dangerously high is 'maximum eval cost' - At 10
million it is over 10 times the amount that Discworld has it at.
mod_channel takes approx 6.5 million instructions to process the
chanlist-reply, I fear it maybe something to do with the excessive
checking in master/valid.c

Richard