savoirfairelinux-openerp team mailing list archive

[Nicolas Bessi - Camptocamp <nicolas.bessi@xxxxxxxxxxxxxx>]

Review: Needs Fixing

Hello, 

Thanks for you proposal. Some comments below.

Global PEP8, please pass your code to a linter (flake8, pylint,…)
Personal advice I'n mot fan of lambdas for default. I would prefer to have a function, but that is just a matter of taste.

for default company you sould use :
self.pool.get('res.company')._company_default_get(cr, uid, 'your_model', context=ctx)

Regards

Nicolas

-- 
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/7.0-document-page-multi-company/+merge/182661
Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/knowledge-addons/7.0-document-page-multi-company.