savoirfairelinux-openerp team mailing list archive

[Virgil Dupras <virgil.dupras@xxxxxxxxxxxxxxxxxxxx>]

Thanks for the review. I'll commit a change for #4 shortly (context passing), but I'm a bit puzzled by other points.

1. By auto_install, you mean explicitly setting it to False, right? I didn't know it was considered good practice.
2. Why do you think one line is preferable to three? Readability?
3. I don't understand why 'state' should be read-only. Isn't this attribute relevant only in views? There's no view for that model.
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/banking-addons/loose-coupling/+merge/185033
Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/banking-addons/loose-coupling.