← Back to team overview

savoirfairelinux-openerp team mailing list archive

Thread
Date

Re: [Merge] lp:~savoirfairelinux-openerp/openerp-hr/7.0-skill into lp:openerp-hr

To: "elhadji.dem@xxxxxxxxxxxxxxxxxxxx" <elhadji.dem@xxxxxxxxxxxxxxxxxxxx>
From: Daniel Reis <dgreis@xxxxxxx>
Date: Thu, 14 Nov 2013 22:28:10 -0000
In-reply-to: <20131114202629.23480.67254.launchpad@ackee.canonical.com>
Reply-to: mp+195302@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Looks good to me.

One remark: the domain for the employee skill_ids is defined on the form; wouldn't be better to have it on the model instead?

-- 
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/7.0-skill/+merge/195302
Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/openerp-hr/7.0-skill.

References

[Merge] lp:~savoirfairelinux-openerp/openerp-hr/7.0-skill into lp:openerp-hr
From: elhadji.dem@xxxxxxxxxxxxxxxxxxxx, 2013-11-14