savoirfairelinux-openerp team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review

s/Edition en masse/Édition en masse/
s/Edition en masse (%s)/Édition en masse (%s)/
--

"Suppression de l'enregistrement de l'action a échoué." is a bit weird.
"La suppression de l'action a échoué." seems better to me.
--

s/Liste de modéle/Liste de modèle/
--

"L'action barre latérale pour faire de ce modèle disponible sur les enregistrements du modèle de document associé" -> pas compris
--

l.301,440 from . import wizard
--

In __openerp__.py, the rst description won't be parsed. Should be:

Mass Editing for Contact Partner
================================

This module allows to remove :

* set and remove options in the wizard

Contributors
------------

* El Hadji Dem (elhadji.dem@xxxxxxxxxxxxxxxxxxxx)

Anyway, the description does not allow to understand the purpose of the module.
Also, how it is related to "Contact Partner". Isn't this change generic? Shouldn't it be part of the mass_editing module?
--

l478-479: empty _columns can be removed
--

481ff in fields_view_get()
context can be None and get() is called, so must add:

    if context is None:
        context = {}
--

l.548 The size is no longer required on fields.char since 7.0 so you shouldn't set an arbitrary length of 256 when empty.
--

l.601: which types of fields are supposed to be covered in the else clause? html for instance?
--

Thanks for your proposal!
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/server-env-tools/mass_editing_contact_partner/+merge/199364
Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/server-env-tools/mass_editing_contact_partner.