savoirfairelinux-openerp team mailing list archive

Thread
Date

Re: lp:~savoirfairelinux-openerp/partner-contact-management/base_contact_by_functions_firstname_lastname into lp:~savoirfairelinux-openerp/partner-contact-management/base_contact_by_functions

To: "elhadji.dem@xxxxxxxxxxxxxxxxxxxx" <elhadji.dem@xxxxxxxxxxxxxxxxxxxx>
From: "Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>
Date: Mon, 23 Dec 2013 19:19:10 -0000
In-reply-to: <20131223164708.32375.38511.launchpad@ackee.canonical.com>
Reply-to: mp+199965@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no test

l.484, 809: what are you doing here?
You have two different (and redundant checks) here.
The result will always be "firstname lastname" because of l.484.
However you check on l.486 which suggests you want to be able to support having either or.
Either way l.485 is redundant.

l.804 why are you suddenly using CamelCase?
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/base_contact_by_functions_firstname_lastname/+merge/199965
Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/partner-contact-management/base_contact_by_functions.

References

lp:~savoirfairelinux-openerp/partner-contact-management/base_contact_by_functions_firstname_lastname into lp:~savoirfairelinux-openerp/partner-contact-management/base_contact_by_functions
From: elhadji.dem@xxxxxxxxxxxxxxxxxxxx, 2013-12-23