savoirfairelinux-openerp team mailing list archive

Thread
Date

Re: [Merge] lp:~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname into lp:openerp-hr

To: "elhadji.dem@xxxxxxxxxxxxxxxxxxxx" <elhadji.dem@xxxxxxxxxxxxxxxxxxxx>
From: Daniel Reis <dgreis@xxxxxxx>
Date: Mon, 03 Feb 2014 09:50:53 -0000
In-reply-to: <20140130194438.5974.33715.launchpad@ackee.canonical.com>
Reply-to: mp+204065@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

Thanks for the contribution. Comments:

L64:  shouldn't the Category be "Human Resources" instead of MISC?
L86:  why is the module declares inactive?
L126: the SQL uses a "name_related" field. I'm not aware of it in standard HR modules. Are you sure this is ok?; also, you're missing a blank line after the method (PEP8).

-- 
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname/+merge/204065
Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname.

References

[Merge] lp:~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname into lp:openerp-hr
From: elhadji.dem@xxxxxxxxxxxxxxxxxxxx, 2014-01-30