savoirfairelinux-openerp team mailing list archive

Thread
Date

Re: [Merge] lp:~savoirfairelinux-openerp/openerp-hr/experience into lp:openerp-hr/6.1

To: "elhadji.dem@xxxxxxxxxxxxxxxxxxxx" <elhadji.dem@xxxxxxxxxxxxxxxxxxxx>
From: "Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>
Date: Thu, 13 Feb 2014 10:15:11 -0000
In-reply-to: <20131112195124.1289.38321.launchpad@ackee.canonical.com>
Reply-to: mp+194926@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no tests

Looks good.

Just one thing about security, I think you just need some ir.rule to make sure hr_user1 can't modify hr_user2 experience data.

You might need a user_id field on all those objects.
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/experience/+merge/194926
Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/openerp-hr/experience.

References

[Merge] lp:~savoirfairelinux-openerp/openerp-hr/experience into lp:openerp-hr/6.1
From: eh.dem, 2013-11-12