← Back to team overview

savoirfairelinux-openerp team mailing list archive

Re: [Merge] lp:~savoirfairelinux-openerp/openerp-mgmtsystem/openupgrade70 into lp:openerp-mgmtsystem

 

Review: Needs Fixing

While you make the method to generate the legacy column name available without OpenUpgrade, you should check if the column exists around l.411. If the database is migrated otherwise, there will be no such column.

What is the use of checking if the openupgrade import is available if you define the functions yourself anyway as a fallback?

-- 
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-mgmtsystem/openupgrade70/+merge/192730
Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/openerp-mgmtsystem/openupgrade70.


References