← Back to team overview

savoirfairelinux-openerp team mailing list archive

Re: [Merge] lp:~savoirfairelinux-openerp/ocb-server/7.0_mail_thread_translate_bug1262000 into lp:ocb-server

 

Review: Needs Fixing

Thanks! Something like this would really help in returning properly translated errors to the user, using _(model._description) in general. However, turning module names in a model name seems a bit simplistic.

Maybe try something like this instead:

=== modified file 'openerp/tools/translate.py'
--- openerp/tools/translate.py	2014-02-06 10:51:41 +0000
+++ openerp/tools/translate.py	2014-02-27 11:46:26 +0000
@@ -670,6 +670,11 @@
             _logger.warning("Unable to find object %r with id %d", model, res_id)
             continue
         obj = pool.get(model).browse(cr, uid, res_id)
+        
+        if model == 'ir.model':
+            model_pool = pool.get(obj.model)
+            if model_pool:
+                push_translation(module, 'code', '_description', 0, model_pool._description)
 
         if model=='ir.ui.view':
             d = etree.XML(encode(obj.arch))


This will give duplicates for every module in which a model is inherited, but this is already the case for the equivalent "model:ir.model,name" entries.
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/7.0_mail_thread_translate_bug1262000/+merge/208488
Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/ocb-server/7.0_mail_thread_translate_bug1262000.


References