savoirfairelinux-openerp team mailing list archive

Thread
Date

Re: [Merge] lp:~savoirfairelinux-openerp/openerp-hr/department_sequence_concatination_NoneType into lp:openerp-hr

To: "Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>
From: Katja Matthes <katja.matthes@xxxxxxxxxx>
Date: Fri, 25 Apr 2014 14:11:13 -0000
In-reply-to: <20140324145421.18096.16774.launchpad@ackee.canonical.com>
Reply-to: mp+212436@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review

Hello,

looks good. Tests run fine.
I think, since you made a fix you should update the module's version number.

Regards.
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/department_sequence_concatination_NoneType/+merge/212436
Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/openerp-hr/department_sequence_concatination_NoneType.

References

[Merge] lp:~savoirfairelinux-openerp/openerp-hr/department_sequence_concatination_NoneType into lp:openerp-hr
From: Sandy Carter (http://www.savoirfairelinux.com), 2014-03-24