savoirfairelinux-openerp team mailing list archive

[Ana Juaristi Olalde <ajuaristio@xxxxxxxxx>]

Review: Needs Fixing

@yannick 
title_bank_account seems useless to me as it isn't even in tree views.

This is a subjective opinion. If someone needs 2 fields, he adds 2 fields. That's all :)

@Elhadji
My oppinion is Need fixing because:

1.  <field name="bank_ids" position="replace">
If you replace bank_ids with something hardcoded on your module view, you will not see new "future" core improvements on that view. 

2. I agree with @yannick in --> Active field already exists on res.partner.bank model. By the way you overide the select=True parameter on it.


-- 
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_res_bank_account/+merge/204047
Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_res_bank_account.