schooltool-developers team mailing list archive

[Tom Hoffman <tom.hoffman@xxxxxxxxx>]

It would be better to have score systems in their own package (in
core) because they should be independent of any gradebook
implementation.  For example, if we add score systems to the journal
we don't want the journal to unnecessarily depend on the gradebook.

--Tom

On Tue, Apr 26, 2011 at 3:36 AM, Alan Elkner <aelkner@xxxxxxxxx> wrote:
> Hey Justas,
>
> Could you please review my latest schooltool.gradebook branch,
> lp:~aelkner/schooltool.gradebook/custom_scoresystems?  Sorry for the
> size of the last commit, but I had so many related changes that I had
> to make in order for tests to pass.  I broke them down briefly in the
> multi-line commit message, but I'll expound on some of the points
> here.
>
> First, I was able to get rid of the ScoreSystemsProxy all together.
> This meant having to change the two existing evolve scripts to
> register utilities manually.  Also, some of the changes to the tests
> resulted from the names, which used to be the utility name (same as
> title), but now are the __name__ of the scoresystem in its container.
>
> A big part of the diff is a consequence of the decision I made to move
> the scoresystems views to the gradebook package.  I did this because
> they use the gradebook root now, and I didn't want to have the
> requirement package depend on the gradebook package.  As it turns out,
> cando only uses the requirement package, not even including the zcml
> for the gradebook, so I didn't want to have any includes of gradebook
> code that would turn out not to be registered in cando.  Also, since
> it was only the views and widgets that I was moving, it was a simple
> enough change requiring no evolution in its own right.
>
> Lastly, I continue to follow your request to break out zcml files as I
> change them, so I created scoresystems.zcml for all the scoresystem
> views and widgets.  I decided to keep the vocabularies there because
> break them out into vocabularies.py and vocabularies.zcml seemed like
> overkill for such a small set of code/registration.  Also, they all
> have to do with scoresystems, anyway.
>
> Please do what you can to look my branch over and give me feedback as
> soon as possible.
>
> Thanks,
> Alan
>
> _______________________________________________
> Mailing list: https://launchpad.net/~schooltool-developers
> Post to     : schooltool-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~schooltool-developers
> More help   : https://help.launchpad.net/ListHelp
>