schooltool-developers team mailing list archive

[Gediminas Paulauskas <menesis@xxxxxx>]

I have fixed both issues today.

2012/6/22 Gediminas Paulauskas <menesis@xxxxxx>:
> 2012/6/21 Douglas Cerna <douglascerna@xxxxxxxxx>:
>> Gediminas:
>>
>> The section_locations.txt stest made me realize that the ommited_items check added in revision 3423 breaks the /resources view (and probably others). Those ommit methods should return lists, or you'll get a permission error on the btree. I fixed them in revision 3425.
>
> It is strange why we would get a permission error. The fix was done to
> avoid creating lists. A copy is still done in TableBatch. I reverted
> your fixed and moved the len() call to where we do have a list.
>
>> The expand_container change made relationships views to use the whole width, which looks weird to me in some cases:
>>
>> http://img36.imageshack.us/img36/8021/pantallazodel2012062113.png
>> http://img843.imageshack.us/img843/8021/pantallazodel2012062113.png
>>
>> Was this style change an accident?
>
> No, the style fix was intentional. I wanted a table with many columns
> to fill whole page width, and found that NoSidebarPage is used for
> that. But its style was expand_container that was not defined
> anywhere. So I made use of existing style and fixed form header in
> such pages.
>
> However, FlourishRelationshipViewBase and EditRelationships, plus
> FlourishContactAddView and FlourishContactEditView, extend
> NoSidebarPage. So they get the fixed style. I think they should extend
> Page instead.
>
> --
> Gediminas



-- 
Gediminas