schooltool-developers team mailing list archive

[Douglas Cerna <douglascerna@xxxxxxxxx>]

Hey everybody.

I just asked Gediminas to double check my changes to the Done links styles, but I thought I should share what's been done:

* We now have a h3.done-link css class for making the link look like a secondary button, so in the future when you need a Done link please use that.

* All these h3.done-link elements now use the i18n:domain="schooltool", no matter the package (gradebook, cando, intervention). My reasoning behind this change is in Gedimina's reply to my email to the developers list titled "Mixing i18n domains and message factories".

* I put some h3.done-link elements in a couple of table filters instead of putting the "button" above the table. I think maybe table filters could be improved (or made more complicated :D) if we allow customization of the buttons from outside. Or maybe I'm getting too much z3c.form oriented!

* In the course index view I moved the Done link out of the content template and put it in the IPageContentManager viewlet manager. Using after="*" allows us to insert content into the page from the plugins (course worksheets, skills overview, etc) and keep the button at the end. You've got to love Flourish!

That's it.

Douglas

"... allí­ es cuando te das cuenta que las cosas malas pueden resultar bastante buenas..." - Lionel Messi

Por favor, evite enviarme adjuntos de Word, Excel o PowerPoint.
Vea http://www.gnu.org/philosophy/no-word-attachments.es.html