screenlets-dev team mailing list archive

[tabbernuk <boamaod@xxxxxxxxx>]

Sensor "cpu_get_load" does not seem to return values in percentage and
should always return data about one processor at a time, so I cannot
really understand this part of bug description.

I hope I fixed "mem_get_usedmem" etc, commited it with revision #569.
Concerning divison with 1024, I think we cannot deliberately change the
format because many screenlets already depend on it. If it is needed, we
can add to sensors.py some extra functions to return data about memory
in other formats, but is it really needed?

About "hddtemp", basically the same, I think we shouldn't deliberately
change the format. But again, if you write extra functions to get
temperature in celsius/fahrenheit, I think this is okay.

Looking at the code, there could be some unifying to be done, because
sometimes temperatures are reported with Celsius indicator and sometimes
without. I'm not sure though, if the it can be unified easily and I
think there are much more critical things to do, so I'm not going to
research into it now. Also, I think it is somehow good, if the unit of
the return value is clearly expressed, but it could be expressed in the
name of the function instead, that would also do it.

** Changed in: screenlets
   Importance: High => Medium

-- 
You received this bug notification because you are a member of
Screenlets Dev Team, which is subscribed to Screenlets.
https://bugs.launchpad.net/bugs/694857

Title:
  [Sensors] sensors.py flaws