sikuli-driver team mailing list archive

[John Henckel <question255872@xxxxxxxxxxxxxxxxxxxxx>]

New question #255872 on Sikuli:
https://answers.launchpad.net/sikuli/+question/255872

Probably i'm stupid, but twice now I've tried to call

region.click(rect)

where rect is java.awt.Rectangle, which is not a supported target type.

The function simply does nothing and returns 0 (which i ignore).  

Don't you suppose it would be better if it throws FindFailed? or else UnsupportedTargetType?

  private <PSIMRL> Location getLocationFromTarget(PSIMRL target) throws FindFailed {
    if (target instanceof Pattern || target instanceof String || target instanceof Image) {
      Match m = find(target);
      if (m != null) {
        if (isOtherScreen()) {
          return m.getTarget().setOtherScreen(scr);
        } else {
          return m.getTarget();
        }
      }
      return null;        <======== SHOULD BE A THROW FINDFAILED
    }
    if (target instanceof Match) {
      return ((Match) target).getTarget();
    }
    if (target instanceof Region) {
      return ((Region) target).getCenter();
    }
    if (target instanceof Location) {
      return new Location((Location) target);
    }
    return null;        <======== SHOULD BE A THROW BAD TARGET TYPE
  }


I can't see any situation where return null is helpful. I think a throw is better.


-- 
You received this question notification because you are a member of
Sikuli Drivers, which is an answer contact for Sikuli.