simple-scan-team team mailing list archive

[Robert Ancell <robert.ancell@xxxxxxxxxxxxx>]

Review: Needs Fixing

Hi,

Thanks very much for that!  The functionality of the patch is correct, but do you mind changing the way it works?  It's a little bit complicated the way it is.

Instead of having the separate loop when get_n_pages() == 1 make make_indexed_file() take a new argument 'n_pages'.  If n_pages == 0 then don't modify the name, otherwise put the numeric suffix on it.

Also note the pages should start at one as requested by Michael in the bug report.
-- 
https://code.launchpad.net/~kroq-gar78/simple-scan/fix-765780/+merge/99859
Your team Simple Scan Development Team is subscribed to branch lp:simple-scan.