simple-scan-team team mailing list archive

[Michael Nagel <ubuntu@xxxxxxxxxxxxxxxxx>]

Robert Ancell added a comment to the merge request and to stop me from
overlooking that, I copy it here:


Hi,

Thanks very much for that! The functionality of the patch is correct,
but do you mind changing the way it works? It's a little bit complicated
the way it is.

Instead of having the separate loop when get_n_pages() == 1 make
make_indexed_file() take a new argument 'n_pages'. If n_pages == 0 then
don't modify the name, otherwise put the numeric suffix on it.

Also note the pages should start at one as requested by Michael in the
bug report.

PS:

Note the reason to avoid the loop when n_pages == 1 is if in the future
we needed to add something after page.save you would have to add it in
two places and one could easily be forgotten.

-- 
You received this bug notification because you are a member of Simple
Scan Development Team, which is the registrant for Simple Scan.
https://bugs.launchpad.net/bugs/765780

Title:
  Add page number for the first file

Status in Simple Scan:
  In Progress

Bug description:
  When saving a document consisting of multiple pages, Simple Scan names files as follows: "file-name.png", "file-name-1.png", "file-name-2.png", ...
  I believe it would be more convenient to add page number to the first file as well: "file-name-1.png", "file-name-2.png", "file-name-3.png", ... 
  Files names would look more consistent this way, and it would be more obvious that the first file also belongs to the same document.

  When saving single page document, no number is needed, for example:
  "file-name.png"

To manage notifications about this bug go to:
https://bugs.launchpad.net/simple-scan/+bug/765780/+subscriptions