simple-scan-team team mailing list archive

[Robert Ancell <robert.ancell@xxxxxxxxxxxxx>]

Review: Disapprove

Hi,

Sorry, I missed with why you changed compress_jpeg - if the code is common to both page.vala and book.vala it should go into it's own module (e.g. jpeg.vala).

However, while this bug does fix the DPI not being set it does mean we can't use the ICC profile support without re-implementing that too (it was commented out but it is supported in gdk-pixbuf). I meant to make a patch to gdk-pixbuf ages ago but I forgot - I've made this now for DPI [1].

I think that once the DPI patch is accepted to gdk-pixbuf we should just use that - it will be simpler for simple-scan without the jpeg code being accessed directly.

Sorry again, I should have picked this up earlier.

[1] https://bugzilla.gnome.org/show_bug.cgi?id=701622
-- 
https://code.launchpad.net/~victor-mireyev/simple-scan/484616/+merge/167359
Your team Simple Scan Development Team is subscribed to branch lp:simple-scan.