simple-scan-team team mailing list archive
-
simple-scan-team team
-
Mailing list archive
-
Message #01061
Re: [Merge] lp:~gotwig/simple-scan/headerbars into lp:simple-scan
I will update the button names. "Looking at the diff below you seem to have moved the app menu logic inside the try clause for no reason - please move it back to the original location. Also there is a whitespace change on line 2521 which doesn't seem relevant."
Ok, I did the app menu logic in another line, to not check twice for has_app_menu().
In your version, the part was missing where you actually add the appmenu.ui file if the application has an app_menu.
--
https://code.launchpad.net/~gotwig/simple-scan/headerbars/+merge/220878
Your team Simple Scan Development Team is subscribed to branch lp:simple-scan.
References